Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 2586203004: [ios] Removed deprecated webViewContainingBlockedImage. (Closed)

Created:
4 years ago by Eugene But (OOO till 7-30)
Modified:
4 years ago
Reviewers:
baxley
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Removed deprecated webViewContainingBlockedImage. BUG=673520 Committed: https://crrev.com/1b250789a63f59686dcac4791fcfb4a270bbc718 Cr-Commit-Position: refs/heads/master@{#439565}

Patch Set 1 #

Patch Set 2 : Fixed compilation #

Patch Set 3 : Removed unnecessary changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -13 lines) Patch
M ios/web/public/test/earl_grey/web_view_matchers.h View 1 chunk +0 lines, -8 lines 0 comments Download
M ios/web/public/test/earl_grey/web_view_matchers.mm View 1 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Eugene But (OOO till 7-30)
4 years ago (2016-12-19 19:37:21 UTC) #2
baxley
lgtm
4 years ago (2016-12-19 21:05:23 UTC) #3
Eugene But (OOO till 7-30)
Thanks for quick review!
4 years ago (2016-12-19 21:07:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2586203004/40001
4 years ago (2016-12-19 21:08:17 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-19 21:20:46 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-19 21:24:03 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1b250789a63f59686dcac4791fcfb4a270bbc718
Cr-Commit-Position: refs/heads/master@{#439565}

Powered by Google App Engine
This is Rietveld 408576698