Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2586203002: Fix memory leak in logging-unittest. (Closed)

Created:
4 years ago by Yang
Modified:
4 years ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix memory leak in logging-unittest. R=cbruni@chromium.org BUG=chromium:662388 Review-Url: https://codereview.chromium.org/2586203002 Cr-Commit-Position: refs/heads/master@{#41799} Committed: https://chromium.googlesource.com/v8/v8/+/2a19ad3603f355c0069f15840ec3d7b2c53fe414

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M test/unittests/base/logging-unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Yang
4 years ago (2016-12-19 10:40:08 UTC) #1
Camillo Bruni
lgtm
4 years ago (2016-12-19 11:31:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2586203002/1
4 years ago (2016-12-19 11:32:05 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-19 11:58:36 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/2a19ad3603f355c0069f15840ec3d7b2c53...

Powered by Google App Engine
This is Rietveld 408576698