Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2586173003: Inline StringCallback::scheduleCallback to the caller (Closed)

Created:
4 years ago by tzik
Modified:
4 years ago
Reviewers:
haraken
CC:
chromium-reviews, sof, eae+blinkwatch, dcheng, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Inline StringCallback::scheduleCallback to the caller Committed: https://crrev.com/f139fb84923af563174a4f09cc1bc39510cfce44 Cr-Commit-Position: refs/heads/master@{#439457}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -66 lines) Patch
M third_party/WebKit/Source/core/clipboard/DataTransferItem.cpp View 2 chunks +9 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/StringCallback.h View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/Source/core/dom/StringCallback.cpp View 1 chunk +0 lines, -52 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
tzik
PTAL
4 years ago (2016-12-19 11:35:05 UTC) #5
haraken
LGTM, thanks
4 years ago (2016-12-19 12:41:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2586173003/1
4 years ago (2016-12-19 13:07:05 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-19 13:11:10 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-19 13:14:04 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f139fb84923af563174a4f09cc1bc39510cfce44
Cr-Commit-Position: refs/heads/master@{#439457}

Powered by Google App Engine
This is Rietveld 408576698