Move kill switch and secure origin checking logic

Move kill switch and secure origin checking logic

Currently the permission kill switch check and secure origin checks happen in
PermissionContextBase::GetPermissionStatus. This function is virtual which
means that it's easy to accidentally override this logic unintentionally,
and hard to insert extra permission checks which take precedence over the user
setting but not over the kill switch.

This CL makes GetPermissionStatus non-virtual such that the kill switch and
origin checking logic is always called and adds a new virtual
GetPermissionStatusInternal function which subclasses can override as needed.

TBR=tommycli@chromium.org

BUG=674389
Committed: https://crrev.com/0f93a5833613dd2786cc45f9c75e2c8723f855f5
Cr-Commit-Position: refs/heads/master@{#439700}

[raymes, 2016-12-19 04:44:52]

The CQ bit was checked by raymes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-19 04:45:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[raymes, 2016-12-19 04:48:26]

raymes@chromium.org changed reviewers:
+ kcarattini@chromium.org

[kcarattini, 2016-12-19 05:14:23]

lgtm

[commit-bot: I haz the power, 2016-12-19 05:23:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 05:23:48]

Dry run: This issue passed the CQ dry run.

[raymes, 2016-12-19 05:36:27]

raymes@chromium.org changed reviewers:
+ peter@chromium.org, sergeyu@chromium.org, tommycli@chromium.org

[raymes, 2016-12-19 05:36:27]

+peter for notifications/
+sergeyu for media/
+tommycli for plugins/

[Peter Beverloo, 2016-12-19 14:14:40]

lgtm

[Sergey Ulanov, 2016-12-20 01:13:10]

lgtm

[raymes, 2016-12-20 04:01:55]

Description was changed from

==========
Move kill switch and secure origin checking logic

Currently the permission kill switch check and secure origin checks happen in
PermissionContextBase::GetPermissionStatus. This function is virtual which
means that it's easy to accidentally override this logic unintentionally,
and hard to insert extra permission checks which take precedence over the user
setting but not over the kill switch.

This CL makes GetPermissionStatus non-virtual such that the kill switch and
origin checking logic is always called and adds a new virtual
GetPermissionStatusInternal function which subclasses can override as needed.

BUG=674389
==========

to

==========
Move kill switch and secure origin checking logic

Currently the permission kill switch check and secure origin checks happen in
PermissionContextBase::GetPermissionStatus. This function is virtual which
means that it's easy to accidentally override this logic unintentionally,
and hard to insert extra permission checks which take precedence over the user
setting but not over the kill switch.

This CL makes GetPermissionStatus non-virtual such that the kill switch and
origin checking logic is always called and adds a new virtual
GetPermissionStatusInternal function which subclasses can override as needed.

TBR=tommycli@chromium.org

BUG=674389
==========

[raymes, 2016-12-20 04:02:19]

TBR=tommycli for trivial change in client code flash_permission_context.*

[raymes, 2016-12-20 04:02:23]

The CQ bit was checked by raymes@chromium.org

[commit-bot: I haz the power, 2016-12-20 04:02:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 04:08:49]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1482206543745350,
"parent_rev": "6cac4639ace81ec07f3efb8a3b690a4197106636", "commit_rev":
"925619041bf41a559c530b00e31f085a4c8a52c1"}

[commit-bot: I haz the power, 2016-12-20 04:09:16]

Description was changed from

==========
Move kill switch and secure origin checking logic

Currently the permission kill switch check and secure origin checks happen in
PermissionContextBase::GetPermissionStatus. This function is virtual which
means that it's easy to accidentally override this logic unintentionally,
and hard to insert extra permission checks which take precedence over the user
setting but not over the kill switch.

This CL makes GetPermissionStatus non-virtual such that the kill switch and
origin checking logic is always called and adds a new virtual
GetPermissionStatusInternal function which subclasses can override as needed.

TBR=tommycli@chromium.org

BUG=674389
==========

to

==========
Move kill switch and secure origin checking logic

Currently the permission kill switch check and secure origin checks happen in
PermissionContextBase::GetPermissionStatus. This function is virtual which
means that it's easy to accidentally override this logic unintentionally,
and hard to insert extra permission checks which take precedence over the user
setting but not over the kill switch.

This CL makes GetPermissionStatus non-virtual such that the kill switch and
origin checking logic is always called and adds a new virtual
GetPermissionStatusInternal function which subclasses can override as needed.

TBR=tommycli@chromium.org

BUG=674389

Review-Url: https://codereview.chromium.org/2586153002
==========

[commit-bot: I haz the power, 2016-12-20 04:09:17]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-20 04:11:41]

Description was changed from

==========
Move kill switch and secure origin checking logic

Currently the permission kill switch check and secure origin checks happen in
PermissionContextBase::GetPermissionStatus. This function is virtual which
means that it's easy to accidentally override this logic unintentionally,
and hard to insert extra permission checks which take precedence over the user
setting but not over the kill switch.

This CL makes GetPermissionStatus non-virtual such that the kill switch and
origin checking logic is always called and adds a new virtual
GetPermissionStatusInternal function which subclasses can override as needed.

TBR=tommycli@chromium.org

BUG=674389

Review-Url: https://codereview.chromium.org/2586153002
==========

to

==========
Move kill switch and secure origin checking logic

Currently the permission kill switch check and secure origin checks happen in
PermissionContextBase::GetPermissionStatus. This function is virtual which
means that it's easy to accidentally override this logic unintentionally,
and hard to insert extra permission checks which take precedence over the user
setting but not over the kill switch.

This CL makes GetPermissionStatus non-virtual such that the kill switch and
origin checking logic is always called and adds a new virtual
GetPermissionStatusInternal function which subclasses can override as needed.

TBR=tommycli@chromium.org

BUG=674389

Committed: https://crrev.com/0f93a5833613dd2786cc45f9c75e2c8723f855f5
Cr-Commit-Position: refs/heads/master@{#439700}
==========

[commit-bot: I haz the power, 2016-12-20 04:11:42]

Patchset 3 (id:??) landed as
https://crrev.com/0f93a5833613dd2786cc45f9c75e2c8723f855f5
Cr-Commit-Position: refs/heads/master@{#439700}