Remove PlatformWheelEvent and use WebMouseWheelEvent instead

third_party/WebKit/Source/web/WebPluginContainerImpl.cpp

Index: third_party/WebKit/Source/web/WebPluginContainerImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp b/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp
index 5660cd411fec17f6ec962b8651a913f25bc58e62..e490cddcc555bd20995f6fd4fe331fd1e4aed752 100644
--- a/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp
+++ b/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp
@@ -759,13 +759,18 @@ void WebPluginContainerImpl::handleDragEvent(MouseEvent* event) {
 }
 
 void WebPluginContainerImpl::handleWheelEvent(WheelEvent* event) {
-  WebMouseWheelEventBuilder webEvent(
-      this, LayoutItem(m_element->layoutObject()), *event);
-  if (webEvent.type == WebInputEvent::Undefined)
-    return;
+  WebMouseWheelEvent translatedEvent = event->nativeEvent();
+  WebFloatPoint absoluteRootFrameLocation =
+      event->nativeEvent().positionInRootFrame();
+  IntPoint localPoint =
+      roundedIntPoint(m_element->layoutObject()->absoluteToLocal(

[majidvp, 2016/12/20 17:30:15]

can |m_element->layoutObject()| be nil? Should we DCHECK that?

[dtapuska, 2017/01/03 20:19:14]

Other places use it unconditionally. I can add a DCHECK if you feel strongly.

+          absoluteRootFrameLocation, UseTransforms));
+  translatedEvent.flattenTransform();
+  translatedEvent.x = localPoint.x();
+  translatedEvent.y = localPoint.y();

[majidvp, 2016/12/20 17:30:15]

he fact that we are doing a flatten but then override the coordinate with the
result of
|absoluteToLocal| is a bit confusing.

I suppose the reason it is done this way is that there may be intermmediate
transforms that should
be taken into account when we translate to plugin space. But then, why are not
these apply to
movement and delta as well?

[dtapuska, 2017/01/03 20:19:14]

Ya I don't know what the best answer here is. But this is logically the same as
it was before.

[majidvp, 2017/01/04 17:32:46]

Fair enough. I filed https://crbug.com/678291 to track this.

 
   WebCursorInfo cursorInfo;
-  if (m_webPlugin->handleInputEvent(webEvent, cursorInfo) !=
+  if (m_webPlugin->handleInputEvent(translatedEvent, cursorInfo) !=
       WebInputEventResult::NotHandled)
     event->setDefaultHandled();
 }