Remove PlatformWheelEvent and use WebMouseWheelEvent instead

third_party/WebKit/Source/web/WebPluginContainerImpl.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  * Copyright (C) 2014 Opera Software ASA. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 741 matching lines @@
       static_cast<WebDragOperationsMask>(dataTransfer->sourceOperation());
   WebPoint dragScreenLocation(event->screenX(), event->screenY());
   WebPoint dragLocation(event->absoluteLocation().x() - location().x(),
                         event->absoluteLocation().y() - location().y());
 
   m_webPlugin->handleDragStatusUpdate(dragStatus, dragData, dragOperationMask,
                                       dragLocation, dragScreenLocation);
 }
 
 void WebPluginContainerImpl::handleWheelEvent(WheelEvent* event) {
-  WebMouseWheelEventBuilder webEvent(
-      this, LayoutItem(m_element->layoutObject()), *event);
-  if (webEvent.type == WebInputEvent::Undefined)
-    return;
+  WebMouseWheelEvent translatedEvent = event->nativeEvent();
+  WebFloatPoint absoluteRootFrameLocation =
+      event->nativeEvent().positionInRootFrame();
+  IntPoint localPoint =
+      roundedIntPoint(m_element->layoutObject()->absoluteToLocal(

[majidvp, 2016/12/20 17:30:15]

can |m_element->layoutObject()| be nil? Should we DCHECK that?

[dtapuska, 2017/01/03 20:19:14]

Other places use it unconditionally. I can add a DCHECK if you feel strongly.

+          absoluteRootFrameLocation, UseTransforms));
+  translatedEvent.flattenTransform();
+  translatedEvent.x = localPoint.x();
+  translatedEvent.y = localPoint.y();

[majidvp, 2016/12/20 17:30:15]

he fact that we are doing a flatten but then override the coordinate with the
result of
|absoluteToLocal| is a bit confusing.

I suppose the reason it is done this way is that there may be intermmediate
transforms that should
be taken into account when we translate to plugin space. But then, why are not
these apply to
movement and delta as well?

[dtapuska, 2017/01/03 20:19:14]

Ya I don't know what the best answer here is. But this is logically the same as
it was before.

[majidvp, 2017/01/04 17:32:46]

Fair enough. I filed https://crbug.com/678291 to track this.

 
   WebCursorInfo cursorInfo;
-  if (m_webPlugin->handleInputEvent(webEvent, cursorInfo) !=
+  if (m_webPlugin->handleInputEvent(translatedEvent, cursorInfo) !=
       WebInputEventResult::NotHandled)
     event->setDefaultHandled();
 }
 
 void WebPluginContainerImpl::handleKeyboardEvent(KeyboardEvent* event) {
   WebKeyboardEventBuilder webEvent(*event);
   if (webEvent.type == WebInputEvent::Undefined)
     return;
 
   if (webEvent.type == WebInputEvent::KeyDown) {
@@ skipping 191 matching lines @@
     // frame view.
     computeClipRectsForPlugin(m_element, windowRect, clipRect, unobscuredRect);
   }
   getPluginOcclusions(m_element, this->parent(), frameRect(), cutOutRects);
   // Convert to the plugin position.
   for (size_t i = 0; i < cutOutRects.size(); i++)
     cutOutRects[i].move(-frameRect().x(), -frameRect().y());
 }
 
 }  // namespace blink