chrome/browser/resources/print_preview/search/destination_list_item.js - Issue 2586113002: MD Settings: ignore modified key events in the profile avatar grid

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/print_preview/search/destination_list_item.js

Issue 2586113002: MD Settings: ignore modified key events in the profile avatar grid (Closed)

Patch Set: closure, take 2 Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/print_preview/print_preview.js ('k') | chrome/browser/resources/settings/people_page/manage_profile.html » ('j') | chrome/test/data/webui/cr_elements/cr_profile_avatar_selector_tests.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/print_preview/search/destination_list_item.js

diff --git a/chrome/browser/resources/print_preview/search/destination_list_item.js b/chrome/browser/resources/print_preview/search/destination_list_item.js

index 48b5b8174f78e0a73664a44c4eb5a44e321edc1c..8b529d45acc919b3f3d5aec44328569b9268b49c 100644

--- a/chrome/browser/resources/print_preview/search/destination_list_item.js

+++ b/chrome/browser/resources/print_preview/search/destination_list_item.js

@@ -227,7 +227,7 @@ cr.define('print_preview', function() {

* @private

onKeyDown_: function(e) {

- if (!e.shiftKey && !e.ctrlKey && !e.altKey && !e.metaKey) {

+ if (!hasKeyModifiers(e)) {

if (e.keyCode == 13) {

var activeElementTag = document.activeElement ?

document.activeElement.tagName.toUpperCase() : '';

@@ -281,7 +281,7 @@ cr.define('print_preview', function() {

* @private

onExtensionIconKeyDown_: function(e) {

- if (e.shiftKey || e.ctrlKey || e.altKey || e.metaKey)

+ if (hasKeyModifiers(e))

return;

if (e.keyCode != 13 /* Enter */)

return;