chrome/browser/resources/print_preview/print_preview.js - Issue 2586113002: MD Settings: ignore modified key events in the profile avatar grid

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/print_preview/print_preview.js

Issue 2586113002: MD Settings: ignore modified key events in the profile avatar grid (Closed)

Patch Set: closure, take 2 Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/print_preview/print_preview.js

diff --git a/chrome/browser/resources/print_preview/print_preview.js b/chrome/browser/resources/print_preview/print_preview.js

index 0c5f7c9cda4444f6bdd7a5b8a1ae175e20753428..afe40161aad25cc88b9f43e1ff0ee15ea7d51810 100644

--- a/chrome/browser/resources/print_preview/print_preview.js

+++ b/chrome/browser/resources/print_preview/print_preview.js

@@ -903,8 +903,7 @@ cr.define('print_preview', function() {

onKeyDown_: function(e) {

// Escape key closes the dialog.

- if (e.keyCode == 27 && !e.shiftKey && !e.ctrlKey && !e.altKey &&

- !e.metaKey) {

+ if (e.keyCode == 27 && !hasKeyModifiers(e)) {

// On non-mac with toolkit-views, ESC key is handled by C++-side instead

// of JS-side.

if (cr.isMac) {