chrome/browser/resources/print_preview/common/overlay.js - Issue 2586113002: MD Settings: ignore modified key events in the profile avatar grid

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/print_preview/common/overlay.js

Issue 2586113002: MD Settings: ignore modified key events in the profile avatar grid (Closed)

Patch Set: closure, take 2 Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/print_preview/common/overlay.js

diff --git a/chrome/browser/resources/print_preview/common/overlay.js b/chrome/browser/resources/print_preview/common/overlay.js

index 4585dd64ae13a19e50a4addfae28fbac4cc04a78..e5f58fadc919e63a5d385d269ce1c9669e799c6b 100644

--- a/chrome/browser/resources/print_preview/common/overlay.js

+++ b/chrome/browser/resources/print_preview/common/overlay.js

@@ -40,7 +40,7 @@ cr.define('print_preview', function() {

this.getElement().addEventListener('keydown', function f(e) {

// Escape pressed -> cancel the dialog.

- if (!e.shiftKey && !e.ctrlKey && !e.altKey && !e.metaKey) {

+ if (!hasKeyModifiers(e)) {

if (e.keyCode == 27) {

e.stopPropagation();

e.preventDefault();