Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/resources/pdf/pdf.js

Issue 2586113002: MD Settings: ignore modified key events in the profile avatar grid (Closed)
Patch Set: closure, take 2 Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/options/cookies_list.js ('k') | chrome/browser/resources/print_preview/common/overlay.js » ('j') | chrome/test/data/webui/cr_elements/cr_profile_avatar_selector_tests.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/pdf/pdf.js
diff --git a/chrome/browser/resources/pdf/pdf.js b/chrome/browser/resources/pdf/pdf.js
index 8db8ba16f94a559e8e11c943398ea1669d866b68..2e2ce5d6b023f7e433f7ee3c3b79b053eecb5b02 100644
--- a/chrome/browser/resources/pdf/pdf.js
+++ b/chrome/browser/resources/pdf/pdf.js
@@ -320,7 +320,7 @@ PDFViewer.prototype = {
pageDownHandler();
return;
case 37: // Left arrow key.
- if (!(e.altKey || e.ctrlKey || e.metaKey || e.shiftKey)) {
+ if (!hasKeyModifiers(e)) {
// Go to the previous page if there are no horizontal scrollbars and
// no form field is focused.
if (!(this.viewport_.documentHasScrollbars().horizontal ||
@@ -341,7 +341,7 @@ PDFViewer.prototype = {
}
return;
case 39: // Right arrow key.
- if (!(e.altKey || e.ctrlKey || e.metaKey || e.shiftKey)) {
+ if (!hasKeyModifiers(e)) {
// Go to the next page if there are no horizontal scrollbars and no
// form field is focused.
if (!(this.viewport_.documentHasScrollbars().horizontal ||
« no previous file with comments | « chrome/browser/resources/options/cookies_list.js ('k') | chrome/browser/resources/print_preview/common/overlay.js » ('j') | chrome/test/data/webui/cr_elements/cr_profile_avatar_selector_tests.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698