Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2586073002: Revert GN declare_args() change. (Closed)

Created:
4 years ago by Dirk Pranke
Modified:
4 years ago
Reviewers:
brettw
CC:
chromium-reviews, Dirk Pranke, tfarina, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert GN declare_args() change. We've seen a bunch of bug reports for flaky build failures complaining about unused or undeclared arguments; it seems possible that this CL might be the cause, so I'm speculatively reverting it and we can see if things get better; reverting the change makes GN more permissive, so this should be reasonably safe. This reverts r433944 (f6fd4d747c77e1c7968eb5af8b195a94a7ed2fac), i.e. https://codereview.chromium.org/2509333003. This CL leaves the build files changes that were in that CL because they are backwards-compatible and improvements regardless. TBR=brettw@chromium.org BUG=674213 Committed: https://crrev.com/8d1f54effdc07f29a6fd00411e453ae3d67f9a86 Cr-Commit-Position: refs/heads/master@{#439366}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -143 lines) Patch
M tools/gn/docs/reference.md View 2 chunks +8 lines, -7 lines 0 comments Download
M tools/gn/functions.h View 2 chunks +1 line, -11 lines 0 comments Download
M tools/gn/functions.cc View 4 chunks +8 lines, -38 lines 0 comments Download
M tools/gn/functions_unittest.cc View 1 chunk +0 lines, -45 lines 0 comments Download
M tools/gn/parse_tree.cc View 1 chunk +1 line, -6 lines 0 comments Download
M tools/gn/scope.h View 2 chunks +1 line, -10 lines 0 comments Download
M tools/gn/scope.cc View 2 chunks +6 lines, -26 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Dirk Pranke
4 years ago (2016-12-18 04:40:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2586073002/1
4 years ago (2016-12-18 04:40:54 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-18 05:13:55 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-18 05:17:13 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8d1f54effdc07f29a6fd00411e453ae3d67f9a86
Cr-Commit-Position: refs/heads/master@{#439366}

Powered by Google App Engine
This is Rietveld 408576698