Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 258603004: Get rid of FromDict from robohornet_pro, scirra, spaceport, sunspider (Closed)

Created:
6 years, 8 months ago by nednguyen
Modified:
6 years, 7 months ago
Reviewers:
dtu, nduca, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Get rid of FromDict from robohornet_pro, scirra, spaceport, sunspider benchmarks. BUG=239179 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266778

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -27 lines) Patch
M tools/perf/benchmarks/robohornet_pro.py View 1 chunk +8 lines, -9 lines 0 comments Download
M tools/perf/benchmarks/scirra.py View 1 chunk +11 lines, -9 lines 0 comments Download
M tools/perf/benchmarks/spaceport.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/perf/benchmarks/sunspider.py View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
nednguyen
6 years, 7 months ago (2014-04-28 21:01:03 UTC) #1
dtu
lgtm
6 years, 7 months ago (2014-04-28 21:38:35 UTC) #2
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 7 months ago (2014-04-28 21:39:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/258603004/1
6 years, 7 months ago (2014-04-28 21:41:14 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 22:11:11 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 7 months ago (2014-04-28 22:11:11 UTC) #6
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 7 months ago (2014-04-28 22:12:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/258603004/1
6 years, 7 months ago (2014-04-28 22:12:46 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 23:37:15 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_x64_rel
6 years, 7 months ago (2014-04-28 23:37:16 UTC) #10
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 7 months ago (2014-04-29 03:57:06 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/258603004/1
6 years, 7 months ago (2014-04-29 03:58:13 UTC) #12
commit-bot: I haz the power
6 years, 7 months ago (2014-04-29 07:55:29 UTC) #13
Message was sent while issue was closed. 
Change committed as 266778

Powered by Google App Engine
This is Rietveld 408576698