tools/perf/benchmarks/spaceport.py - Issue 258603004: Get rid of FromDict from robohornet_pro, scirra, spaceport, sunspider

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/benchmarks/spaceport.py

Issue 258603004: Get rid of FromDict from robohornet_pro, scirra, spaceport, sunspider (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/benchmarks/spaceport.py

diff --git a/tools/perf/benchmarks/spaceport.py b/tools/perf/benchmarks/spaceport.py

index 4eca5f96be6504dc6e53f0f949d0dcef72875d43..f4cc522af66b3ad8ce265732391bd1b2201de643 100644

--- a/tools/perf/benchmarks/spaceport.py

+++ b/tools/perf/benchmarks/spaceport.py

@@ -73,6 +73,6 @@ class Spaceport(test.Test):

def CreatePageSet(self, options):

spaceport_dir = os.path.join(util.GetChromiumSrcDir(), 'chrome', 'test',

'data', 'third_party', 'spaceport')

- return page_set.PageSet.FromDict(

- {'pages': [{'url': 'file://index.html'}]},

- spaceport_dir)

+ ps = page_set.PageSet(file_path=spaceport_dir)

+ ps.AddPageWithDefaultRunNavigate('file://index.html')

+ return ps

« no previous file with comments | « tools/perf/benchmarks/scirra.py ('k') | tools/perf/benchmarks/sunspider.py » ('j') | no next file with comments »