Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2585993002: Revert of [android] Make RWHVAndroid a BeginFrameObserver. (Closed)

Created:
4 years ago by rnephew (Reviews Here)
Modified:
4 years ago
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, nona+watch_chromium.org, darin-cc_chromium.org, James Su, sunnyps, danakj, enne (OOO), brianderson, Sami
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [android] Make RWHVAndroid a BeginFrameObserver. (patchset #4 id:120001 of https://codereview.chromium.org/2564403002/ ) Reason for revert: Expected failure of telemetry_perf_unittests crbug.com/675289 Original issue's description: > [android] Make RWHVAndroid a BeginFrameObserver. > > Instead of directly observing the Window's vsyncs, RWHVAndroid now > observes a BeginFrameSource provided by the DelegatedFrameHost (clank) > or WindowAndroid (webview). To enable this, the BeginFrameSource > originally provided by CompositorImpl moves into WindowAndroid. > > The patch also makes some changes to the BeginFrameSource's observer > iteration that are necessary to support > SynchronousBrowserCompositorFilter. > > BUG=401336 > > Committed: https://crrev.com/1a6bd5037fc10e45646715d675e63146d23fc28d > Cr-Commit-Position: refs/heads/master@{#439072} TBR=boliu@chromium.org,tedchoc@chromium.org,brianderson@chromium.org,eseckler@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=401336 Committed: https://crrev.com/8bcaf5f12f1901319a20d6ecc67c177c70e0b364 Cr-Commit-Position: refs/heads/master@{#439316}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+261 lines, -284 lines) Patch
M content/browser/android/synchronous_compositor_browser_filter.h View 3 chunks +10 lines, -8 lines 0 comments Download
M content/browser/android/synchronous_compositor_browser_filter.cc View 3 chunks +28 lines, -17 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.h View 5 chunks +16 lines, -0 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 7 chunks +101 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.h View 8 chunks +14 lines, -25 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 13 chunks +68 lines, -92 lines 0 comments Download
M ui/android/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M ui/android/delegated_frame_host_android.h View 2 chunks +4 lines, -8 lines 0 comments Download
M ui/android/delegated_frame_host_android.cc View 2 chunks +9 lines, -7 lines 0 comments Download
M ui/android/window_android.h View 5 chunks +2 lines, -15 lines 0 comments Download
M ui/android/window_android.cc View 5 chunks +5 lines, -110 lines 0 comments Download
M ui/android/window_android_compositor.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/android/window_android_observer.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
rnephew (Reviews Here)
Created Revert of [android] Make RWHVAndroid a BeginFrameObserver.
4 years ago (2016-12-17 04:11:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2585993002/1
4 years ago (2016-12-17 04:11:20 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-17 04:14:51 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-17 04:18:53 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8bcaf5f12f1901319a20d6ecc67c177c70e0b364
Cr-Commit-Position: refs/heads/master@{#439316}

Powered by Google App Engine
This is Rietveld 408576698