Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 2585943002: Make helpful announcement when there's no focus (Closed)

Created:
4 years ago by David Tseng
Modified:
4 years ago
Reviewers:
dmazzoni
CC:
chromium-reviews, alemate+watch_chromium.org, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make helpful announcement when there's no focus BUG=638705 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/c689031affc2246cb94c98a707d5ab7c7b737993 Cr-Commit-Position: refs/heads/master@{#439606}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/command_handler.js View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
David Tseng
4 years ago (2016-12-16 23:39:57 UTC) #4
dmazzoni
lgtm Excellent idea to add a helpful announcement. Rather than "no focus" I wonder if ...
4 years ago (2016-12-19 21:44:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2585943002/1
4 years ago (2016-12-19 21:45:11 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-19 23:15:30 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c689031affc2246cb94c98a707d5ab7c7b737993 Cr-Commit-Position: refs/heads/master@{#439606}
4 years ago (2016-12-19 23:17:57 UTC) #12
David Tseng
3 years, 11 months ago (2017-01-10 17:55:00 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2626683002/ by dtseng@chromium.org.

The reason for reverting is: Interferes with ARC++; blocked on native ARC++
ChromeVox support.
BUG=679760.

Powered by Google App Engine
This is Rietveld 408576698