Return unique_ptr<> from IPDF_StructTree

Return unique_ptr<> from IPDF_StructTree

Delete some dead code in the process.

Review-Url: https://codereview.chromium.org/2585873002
Committed: https://pdfium.googlesource.com/pdfium/+/d5b81ce5722398cc8c259d76e7cd1a5ddc2c562f

[Tom Sepez, 2016-12-16 20:02:10]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 20:02:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-12-16 20:02:36]

Description was changed from

==========
Return unique_ptr<> from IPDF_StructTree

Delete some dead code in the process.
==========

to

==========
Return unique_ptr<> from IPDF_StructTree

Delete some dead code in the process.
==========

[Tom Sepez, 2016-12-16 20:02:36]

tsepez@chromium.org changed reviewers:
+ npm@chromium.org, weili@chromium.org

[Tom Sepez, 2016-12-16 20:02:49]

npm, wei, ready for review.

[commit-bot: I haz the power, 2016-12-16 20:16:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 20:16:27]

Dry run: This issue passed the CQ dry run.

[Wei Li, 2016-12-16 20:26:33]

lgtm

https://codereview.chromium.org/2585873002/diff/1/core/fpdfdoc/doc_tagged.cpp
File core/fpdfdoc/doc_tagged.cpp (right):

https://codereview.chromium.org/2585873002/diff/1/core/fpdfdoc/doc_tagged.cpp...
core/fpdfdoc/doc_tagged.cpp:44: return std::move(pTree);
Nit: move() is not needed here

[Tom Sepez, 2016-12-16 22:45:18]

https://codereview.chromium.org/2585873002/diff/1/core/fpdfdoc/doc_tagged.cpp
File core/fpdfdoc/doc_tagged.cpp (right):

https://codereview.chromium.org/2585873002/diff/1/core/fpdfdoc/doc_tagged.cpp...
core/fpdfdoc/doc_tagged.cpp:44: return std::move(pTree);
On 2016/12/16 20:26:33, Wei Li wrote:
> Nit: move() is not needed here

Sadly, it is required, because the return type is an unique_ptr to a superclass
of the actual unique_ptr, and that breaks on android's old tool chain without
the move.

[Tom Sepez, 2016-12-16 22:45:23]

The CQ bit was checked by tsepez@chromium.org

[commit-bot: I haz the power, 2016-12-16 22:45:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 22:45:46]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481928323101510, "parent_rev":
"ad3cd2aeff15bd31aa38544063075d910ac63823", "commit_rev":
"d5b81ce5722398cc8c259d76e7cd1a5ddc2c562f"}

[commit-bot: I haz the power, 2016-12-16 22:45:49]

Description was changed from

==========
Return unique_ptr<> from IPDF_StructTree

Delete some dead code in the process.
==========

to

==========
Return unique_ptr<> from IPDF_StructTree

Delete some dead code in the process.

Review-Url: https://codereview.chromium.org/2585873002
Committed:
https://pdfium.googlesource.com/pdfium/+/d5b81ce5722398cc8c259d76e7cd1a5ddc2c...
==========

[commit-bot: I haz the power, 2016-12-16 22:45:49]

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/d5b81ce5722398cc8c259d76e7cd1a5ddc2c...