Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(809)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2585863002: Ensure network activity is stopped on deallocation. (Closed)

Created:
4 years ago by michaeldo
Modified:
4 years ago
CC:
chromium-reviews, pkl (ping after 24h if needed), sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure network activity is stopped on deallocation. BUG=620887 Committed: https://crrev.com/82b76f7d28b24b91aa866bb2710de55820dd63c3 Cr-Commit-Position: refs/heads/master@{#439180}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M ios/chrome/browser/web/network_activity_indicator_tab_helper.mm View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
michaeldo
4 years ago (2016-12-16 19:49:33 UTC) #3
Eugene But (OOO till 7-30)
lgtm lgtm, but please move common code to Stop in a separate CL
4 years ago (2016-12-16 19:51:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2585863002/1
4 years ago (2016-12-16 19:52:55 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-16 20:50:02 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-16 20:54:16 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/82b76f7d28b24b91aa866bb2710de55820dd63c3
Cr-Commit-Position: refs/heads/master@{#439180}

Powered by Google App Engine
This is Rietveld 408576698