Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2585823003:
Enforce check on how many pref updates and cache updates are called in http_server_properties_manag… (Closed)
|
Created:
4 years ago by Zhongyi Shi Modified:
4 years ago Reviewers:
xunjieli CC:
chromium-reviews, cbentzel+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionEnforce check on how many pref updates and cache updates are called in http_server_properties_manager_unittests
BUG=670519
Committed: https://crrev.com/3eb8769e7bf92c387b60860e85470b49b4a3fd80
Cr-Commit-Position: refs/heads/master@{#439535}
Patch Set 1 #Patch Set 2 : rebase with master #
Total comments: 2
Patch Set 3 : add times checking in pref update call #
Total comments: 2
Patch Set 4 : fix #Messages
Total messages: 17 (8 generated)
Description was changed from ========== Enforce check on how many pref updates and cache Updates are called in http_server_properties_manager_unittests BUG=670519 ========== to ========== Enforce check on how many pref updates and cache updates are called in http_server_properties_manager_unittests BUG=670519 ==========
zhongyi@chromium.org changed reviewers: + xunjieli@chromium.org
Patchset #1 (id:1) has been deleted
Patchset #2 (id:40001) has been deleted
LGTM. Thanks for following up on this. https://codereview.chromium.org/2585823003/diff/60001/net/http/http_server_pr... File net/http/http_server_properties_manager_unittest.cc (right): https://codereview.chromium.org/2585823003/diff/60001/net/http/http_server_pr... net/http/http_server_properties_manager_unittest.cc:216: void ExpectScheduleUpdatePrefsOnNetworkThreadRepeatedly() { Will you get to this one in a later CL? I wanted to make sure that the number of scheduled updates can be greater than actual number of updates.
https://codereview.chromium.org/2585823003/diff/60001/net/http/http_server_pr... File net/http/http_server_properties_manager_unittest.cc (right): https://codereview.chromium.org/2585823003/diff/60001/net/http/http_server_pr... net/http/http_server_properties_manager_unittest.cc:216: void ExpectScheduleUpdatePrefsOnNetworkThreadRepeatedly() { On 2016/12/19 15:48:18, xunjieli wrote: > Will you get to this one in a later CL? > I wanted to make sure that the number of scheduled updates can be greater than > actual number of updates. Ah, I added another check here. PTAL!
https://codereview.chromium.org/2585823003/diff/80001/net/http/http_server_pr... File net/http/http_server_properties_manager_unittest.cc (right): https://codereview.chromium.org/2585823003/diff/80001/net/http/http_server_pr... net/http/http_server_properties_manager_unittest.cc:672: ExpectScheduleUpdatePrefsOnNetworkThreadRepeatedly(2); Should this be 3 instead of 2?
https://codereview.chromium.org/2585823003/diff/80001/net/http/http_server_pr... File net/http/http_server_properties_manager_unittest.cc (right): https://codereview.chromium.org/2585823003/diff/80001/net/http/http_server_pr... net/http/http_server_properties_manager_unittest.cc:672: ExpectScheduleUpdatePrefsOnNetworkThreadRepeatedly(2); On 2016/12/19 18:46:43, xunjieli wrote: > Should this be 3 instead of 2? Oh, yeah, since we set the SupportsSpdy three times, we should expect three times! Sorry about the typo :(
lgtm
The CQ bit was checked by zhongyi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 100001, "attempt_start_ts": 1482175988138840,
"parent_rev": "55e9437837f6587656cc2e7b276d7dcb0cbb7566", "commit_rev":
"67f2a143eabac6e9b8cd37da6233db38f3688c97"}
Message was sent while issue was closed.
Description was changed from ========== Enforce check on how many pref updates and cache updates are called in http_server_properties_manager_unittests BUG=670519 ========== to ========== Enforce check on how many pref updates and cache updates are called in http_server_properties_manager_unittests BUG=670519 Review-Url: https://codereview.chromium.org/2585823003 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:100001)
Message was sent while issue was closed.
Description was changed from ========== Enforce check on how many pref updates and cache updates are called in http_server_properties_manager_unittests BUG=670519 Review-Url: https://codereview.chromium.org/2585823003 ========== to ========== Enforce check on how many pref updates and cache updates are called in http_server_properties_manager_unittests BUG=670519 Committed: https://crrev.com/3eb8769e7bf92c387b60860e85470b49b4a3fd80 Cr-Commit-Position: refs/heads/master@{#439535} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/3eb8769e7bf92c387b60860e85470b49b4a3fd80 Cr-Commit-Position: refs/heads/master@{#439535} |
