Revert "Revert of Implement GetDisplayed on android M+ (patchset #3 id:60001 of https://codereview.…

Revert "Revert of Implement GetDisplayed on android M+ (patchset #3 id:60001 of https://codereview.chromium.org/2536313003/ )"

This reverts commit 06b647e40c84fb6d13e09b13eabfa201b0aa6a32.

It also includes an extra null check in case no active notifications are
returned.

TBR=peter,avi

BUG=

Committed: https://crrev.com/ef0ab6b078544507d8ae76371bc962095858554d
Cr-Commit-Position: refs/heads/master@{#439278}

[Miguel Garcia, 2016-12-16 18:25:04]

The CQ bit was checked by miguelg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 18:25:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Miguel Garcia, 2016-12-16 18:34:34]

Description was changed from

==========
Revert "Revert of Implement GetDisplayed on android M+ (patchset #3 id:60001 of
https://codereview.chromium.org/2536313003/ )"

This reverts commit 06b647e40c84fb6d13e09b13eabfa201b0aa6a32.

It also includes an extra null check in case no active notifications are
returned.

BUG=
==========

to

==========
Revert "Revert of Implement GetDisplayed on android M+ (patchset #3 id:60001 of
https://codereview.chromium.org/2536313003/ )"

This reverts commit 06b647e40c84fb6d13e09b13eabfa201b0aa6a32.

It also includes an extra null check in case no active notifications are
returned.

TBR=peter,avi

BUG=
==========

[Miguel Garcia, 2016-12-16 18:34:34]

miguelg@chromium.org changed reviewers:
+ avi@chromium.org, peter@rybin.spb.ru

[Miguel Garcia, 2016-12-16 18:35:59]

The CQ bit was unchecked by miguelg@chromium.org

[Miguel Garcia, 2016-12-16 18:36:00]

The CQ bit was checked by miguelg@chromium.org

[commit-bot: I haz the power, 2016-12-16 18:36:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Miguel Garcia, 2016-12-16 18:37:19]

The CQ bit was unchecked by miguelg@chromium.org

[Miguel Garcia, 2016-12-16 18:56:26]

The CQ bit was checked by miguelg@chromium.org

[commit-bot: I haz the power, 2016-12-16 18:56:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 20:49:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 20:49:55]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Miguel Garcia, 2016-12-17 00:33:33]

The CQ bit was checked by miguelg@chromium.org

[commit-bot: I haz the power, 2016-12-17 00:34:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-17 01:27:30]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481934813614640, "parent_rev":
"b9c70606793cb7a4c881692be01492a6804f9ab9", "commit_rev":
"9463e5b5f75aa9556c0a79887f81a43519fed8fc"}

[commit-bot: I haz the power, 2016-12-17 01:28:24]

Description was changed from

==========
Revert "Revert of Implement GetDisplayed on android M+ (patchset #3 id:60001 of
https://codereview.chromium.org/2536313003/ )"

This reverts commit 06b647e40c84fb6d13e09b13eabfa201b0aa6a32.

It also includes an extra null check in case no active notifications are
returned.

TBR=peter,avi

BUG=
==========

to

==========
Revert "Revert of Implement GetDisplayed on android M+ (patchset #3 id:60001 of
https://codereview.chromium.org/2536313003/ )"

This reverts commit 06b647e40c84fb6d13e09b13eabfa201b0aa6a32.

It also includes an extra null check in case no active notifications are
returned.

TBR=peter,avi

BUG=

Review-Url: https://codereview.chromium.org/2585823002
==========

[commit-bot: I haz the power, 2016-12-17 01:28:25]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-17 01:32:16]

Description was changed from

==========
Revert "Revert of Implement GetDisplayed on android M+ (patchset #3 id:60001 of
https://codereview.chromium.org/2536313003/ )"

This reverts commit 06b647e40c84fb6d13e09b13eabfa201b0aa6a32.

It also includes an extra null check in case no active notifications are
returned.

TBR=peter,avi

BUG=

Review-Url: https://codereview.chromium.org/2585823002
==========

to

==========
Revert "Revert of Implement GetDisplayed on android M+ (patchset #3 id:60001 of
https://codereview.chromium.org/2536313003/ )"

This reverts commit 06b647e40c84fb6d13e09b13eabfa201b0aa6a32.

It also includes an extra null check in case no active notifications are
returned.

TBR=peter,avi

BUG=

Committed: https://crrev.com/ef0ab6b078544507d8ae76371bc962095858554d
Cr-Commit-Position: refs/heads/master@{#439278}
==========

[commit-bot: I haz the power, 2016-12-17 01:32:17]

Patchset 1 (id:??) landed as
https://crrev.com/ef0ab6b078544507d8ae76371bc962095858554d
Cr-Commit-Position: refs/heads/master@{#439278}

[gone, 2016-12-20 20:15:00]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2589333002/ by dfalcantara@chromium.org.

The reason for reverting is:
org.chromium.chrome.browser.push_messaging.PushMessagingTest#testDefaultNotification
is still failing consistently on the Marshmallow bots:

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType...

Example log:
https://build.chromium.org/p/chromium.android/builders/Marshmallow%2064%20bit...

org.chromium.chrome.browser.push_messaging.PushMessagingTest#testDefaultNotification
(run #1):
junit.framework.AssertionFailedError: expected:<1> but was:<2>
	at
org.chromium.chrome.browser.notifications.NotificationTestBase.waitForNotification(NotificationTestBase.java:107)
	at
org.chromium.chrome.browser.push_messaging.PushMessagingTest.testDefaultNotification(PushMessagingTest.java:246)
	at
android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
	at
android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
	at
android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
	at
org.chromium.chrome.test.ChromeActivityTestCaseBase.runTest(ChromeActivityTestCaseBase.java:752)
	at
org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161)
	at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
	at
android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:555)
	at
android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1879).