Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1298)

Unified Diff: third_party/WebKit/Source/wtf/dtoa/double.h

Issue 2585673002: Replace ASSERT, ENABLE(ASSERT), and ASSERT_NOT_REACHED in wtf (Closed)
Patch Set: Fix an Asan issue with LinkedHashSetNodeBase::unlink Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/wtf/dtoa/diy-fp.h ('k') | third_party/WebKit/Source/wtf/dtoa/double-conversion.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/wtf/dtoa/double.h
diff --git a/third_party/WebKit/Source/wtf/dtoa/double.h b/third_party/WebKit/Source/wtf/dtoa/double.h
index 9aa2df72f39df0dc220093c18f68cb991a9ff90f..686c2e64c53b55a8cba3b5767589d0afc6f706f7 100644
--- a/third_party/WebKit/Source/wtf/dtoa/double.h
+++ b/third_party/WebKit/Source/wtf/dtoa/double.h
@@ -60,14 +60,14 @@ class Double {
// The value encoded by this Double must be greater or equal to +0.0.
// It must not be special (infinity, or NaN).
DiyFp AsDiyFp() const {
- ASSERT(Sign() > 0);
- ASSERT(!IsSpecial());
+ DCHECK_GT(Sign(), 0);
+ DCHECK(!IsSpecial());
return DiyFp(Significand(), Exponent());
}
// The value encoded by this Double must be strictly greater than 0.
DiyFp AsNormalizedDiyFp() const {
- ASSERT(value() > 0.0);
+ DCHECK_GT(value(), 0.0);
uint64_t f = Significand();
int e = Exponent();
@@ -153,7 +153,7 @@ class Double {
// Precondition: the value encoded by this Double must be greater or equal
// than +0.0.
DiyFp UpperBoundary() const {
- ASSERT(Sign() > 0);
+ DCHECK_GT(Sign(), 0);
return DiyFp(Significand() * 2 + 1, Exponent() - 1);
}
@@ -162,7 +162,7 @@ class Double {
// exponent as m_plus.
// Precondition: the value encoded by this Double must be greater than 0.
void NormalizedBoundaries(DiyFp* out_m_minus, DiyFp* out_m_plus) const {
- ASSERT(value() > 0.0);
+ DCHECK_GT(value(), 0.0);
DiyFp v = this->AsDiyFp();
bool significand_is_zero = (v.f() == kHiddenBit);
DiyFp m_plus = DiyFp::Normalize(DiyFp((v.f() << 1) + 1, v.e() - 1));
« no previous file with comments | « third_party/WebKit/Source/wtf/dtoa/diy-fp.h ('k') | third_party/WebKit/Source/wtf/dtoa/double-conversion.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698