Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issue 2585643002: Always show 'WEB SEARCH' item in action mode on Chrome (Closed)

Created:
4 years ago by Jinsuk Kim
Modified:
4 years ago
Reviewers:
boliu
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Always show 'WEB SEARCH' item in action mode on Chrome There was a regression not showing web search menu item in select action mode on Chrome if an activity for ACTION_WEB_SEARCH cannot be found in the system. Chrome should always show it since it can show the search result on a new tab. This CL fixes it by showing the item by default, and having other embedder (webview) configure it. BUG=674104 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2577963002 Cr-Commit-Position: refs/heads/master@{#439000} (cherry picked from commit 1f1083f8bf08eeda6a0e9a48dc9e16a8dca15b9f) Review-Url: https://codereview.chromium.org/2585643002

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -13 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwActionModeCallback.java View 3 chunks +19 lines, -2 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 1 chunk +2 lines, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java View 2 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Jinsuk Kim
Merging to branch M56
4 years ago (2016-12-16 04:15:22 UTC) #1
Jinsuk Kim
4 years ago (2016-12-16 22:49:39 UTC) #3
boliu
lgtm
4 years ago (2016-12-16 22:50:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2585643002/1
4 years ago (2016-12-16 22:53:20 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-16 22:57:11 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698