Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2585633002: Fix duplicate name warnings from make_zip, and pass allowZip64. (Closed)

Created:
4 years ago by skobes
Modified:
4 years ago
Reviewers:
Michael Moss
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix duplicate name warnings from make_zip, and pass allowZip64. BUG=672060, 672851 Committed: https://crrev.com/1e73d181fd4eb9868a26c995079881d07d5819a9 Cr-Commit-Position: refs/heads/master@{#439159}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/tools/build/make_zip.py View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
skobes
4 years ago (2016-12-16 04:13:35 UTC) #2
Michael Moss
lgtm
4 years ago (2016-12-16 04:47:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2585633002/1
4 years ago (2016-12-16 18:33:16 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-16 18:43:45 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-16 18:46:30 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1e73d181fd4eb9868a26c995079881d07d5819a9
Cr-Commit-Position: refs/heads/master@{#439159}

Powered by Google App Engine
This is Rietveld 408576698