Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2585613002:
Roll back iOS hermetic toolchain to 8.0. (Closed)
|
Created:
4 years ago by justincohen Modified:
4 years ago Reviewers:
rohitrao (ping after 24h) CC:
chromium-reviews, mac-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRoll back iOS hermetic toolchain to 8.0.
BUG=
Committed: https://crrev.com/3027e592f8303d46dd15f1d3d5c758a2c6a4b844
Cr-Commit-Position: refs/heads/master@{#439057}
Patch Set 1 #
Messages
Total messages: 16 (9 generated)
justincohen@chromium.org changed reviewers: + rohitrao@chromium.org
ptal -- this may not be necessary, but queuing up just incase.
What is SUB_REVISION? Were we using 8.0 or 8.1 for official builds?
Sub revision is because we updated the package script and -1 is a larger, older zip. Current hermetic is using 8.1
The CQ bit was checked by rohitrao@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Switching back to the 8.0 SDK lgtm if the bots are happy
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by justincohen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481871932648210, "parent_rev":
"000a10249cc10bfb70784133f02719d0685d965c", "commit_rev":
"5c7490f0c34238ec53a26b42420fbc74ee62c221"}
Message was sent while issue was closed.
Description was changed from ========== Roll back iOS hermetic toolchain to 8.0. BUG= ========== to ========== Roll back iOS hermetic toolchain to 8.0. BUG= Review-Url: https://codereview.chromium.org/2585613002 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Roll back iOS hermetic toolchain to 8.0. BUG= Review-Url: https://codereview.chromium.org/2585613002 ========== to ========== Roll back iOS hermetic toolchain to 8.0. BUG= Committed: https://crrev.com/3027e592f8303d46dd15f1d3d5c758a2c6a4b844 Cr-Commit-Position: refs/heads/master@{#439057} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/3027e592f8303d46dd15f1d3d5c758a2c6a4b844 Cr-Commit-Position: refs/heads/master@{#439057} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
