DescriptionConverts services/navigation to use aura-mus
This code won't actually work. There are a couple of things that need
to be fixed for it to work:
. My understanding from looking at the code is that it will create
multiple WindowTreeClients in the same thread. That can work, but when
you do that you have to explicitly pass a WindowPortMus to Windows
when you create them. That's hard in this case because
DesktopNativeWidgetAura is creating the windows for you. The fix
isn't hard, probably set the WindowTreeClient in
DesktopNativeWidgetAura so that it can create WindowPort correctly.
. aura::WindowTreeClientDelegate has a couple of functions that can't
be implemented in ViewImpl. Specifically getting the capture client
and a PropertyConverter. The capture client generally comes from
WMState and the PropertyConverter can be a singleton. It shouldn't
be that hard to wire these up.
. aura::Env needs to be created with Mode::MUS.
As my understanding is I can't really run this code yet I didn't
pursue the fixes. If there is a way to run this code I can try and
make these fixes, otherwise I would prefer to postpone.
BUG=674757
TEST=none
R=ben@chromium.org
Committed: https://crrev.com/5b18f736c212371ac7a8bbe985b44fbf018f1d06
Cr-Commit-Position: refs/heads/master@{#439036}
Patch Set 1 #Patch Set 2 : comment #
Messages
Total messages: 12 (7 generated)
|