Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Issue 2585593002: Converts services/navigation to use aura-mus (Closed)

Created:
4 years ago by sky
Modified:
4 years ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Converts services/navigation to use aura-mus This code won't actually work. There are a couple of things that need to be fixed for it to work: . My understanding from looking at the code is that it will create multiple WindowTreeClients in the same thread. That can work, but when you do that you have to explicitly pass a WindowPortMus to Windows when you create them. That's hard in this case because DesktopNativeWidgetAura is creating the windows for you. The fix isn't hard, probably set the WindowTreeClient in DesktopNativeWidgetAura so that it can create WindowPort correctly. . aura::WindowTreeClientDelegate has a couple of functions that can't be implemented in ViewImpl. Specifically getting the capture client and a PropertyConverter. The capture client generally comes from WMState and the PropertyConverter can be a singleton. It shouldn't be that hard to wire these up. . aura::Env needs to be created with Mode::MUS. As my understanding is I can't really run this code yet I didn't pursue the fixes. If there is a way to run this code I can try and make these fixes, otherwise I would prefer to postpone. BUG=674757 TEST=none R=ben@chromium.org Committed: https://crrev.com/5b18f736c212371ac7a8bbe985b44fbf018f1d06 Cr-Commit-Position: refs/heads/master@{#439036}

Patch Set 1 #

Patch Set 2 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -21 lines) Patch
M services/navigation/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M services/navigation/view_impl.h View 6 chunks +14 lines, -8 lines 0 comments Download
M services/navigation/view_impl.cc View 1 4 chunks +41 lines, -12 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
sky
4 years ago (2016-12-16 00:42:56 UTC) #1
Ben Goodger (Google)
lgtm
4 years ago (2016-12-16 00:46:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2585593002/20001
4 years ago (2016-12-16 00:47:35 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-16 05:34:43 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-16 05:36:41 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5b18f736c212371ac7a8bbe985b44fbf018f1d06
Cr-Commit-Position: refs/heads/master@{#439036}

Powered by Google App Engine
This is Rietveld 408576698