Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2585583007: Remove recipes.py and friends from chromium/src (for now). (Closed)

Created:
4 years ago by iannucci
Modified:
3 years, 11 months ago
Reviewers:
dnj, Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove recipes.py and friends from chromium/src (for now). Until we have a better testing/rolling strategy, we're removing recipes from chromium/src. R=dnj@chromium.org, dpranke@chromium.org BUG=chromium:584079 Review-Url: https://codereview.chromium.org/2585583007 Cr-Commit-Position: refs/heads/master@{#442172} Committed: https://chromium.googlesource.com/chromium/src/+/c5560a91769c4495c6669d147e3bc024c7d28019

Patch Set 1 #

Patch Set 2 : Remove presubmit too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -237 lines) Patch
D infra/PRESUBMIT.py View 1 1 chunk +0 lines, -19 lines 0 comments Download
M infra/README.md View 1 chunk +0 lines, -4 lines 0 comments Download
D infra/config/recipes.cfg View 1 chunk +0 lines, -21 lines 0 comments Download
D infra/recipes.py View 1 chunk +0 lines, -170 lines 0 comments Download
D infra/unittests/recipes_test.py View 1 1 chunk +0 lines, -23 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
iannucci
4 years ago (2016-12-17 00:20:18 UTC) #1
Dirk Pranke
lgtm
4 years ago (2016-12-18 02:58:25 UTC) #2
dnj
lgtm. FWIW I intentionally left it in there when I cleared the actual recipes themselves ...
4 years ago (2016-12-18 15:53:33 UTC) #3
Dirk Pranke
On 2016/12/18 15:53:33, dnj wrote: > lgtm. FWIW I intentionally left it in there when ...
4 years ago (2016-12-18 17:40:54 UTC) #4
iannucci
On 2016/12/18 17:40:54, Dirk Pranke wrote: > On 2016/12/18 15:53:33, dnj wrote: > > lgtm. ...
4 years ago (2016-12-18 19:09:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2585583007/1
4 years ago (2016-12-18 19:10:01 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/328605)
4 years ago (2016-12-18 19:16:11 UTC) #9
iannucci
ptal again. Looks like I missed the test stuff too. I suspect it's better to ...
4 years ago (2016-12-19 03:41:13 UTC) #10
Dirk Pranke
agreed. still lgtm.
4 years ago (2016-12-19 05:51:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2585583007/20001
3 years, 11 months ago (2017-01-07 21:23:25 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-07 21:33:20 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c5560a91769c4495c6669d147e3b...

Powered by Google App Engine
This is Rietveld 408576698