Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 2585583006: Move register allocation unittests and constrain owners (Closed)

Created:
4 years ago by Mircea Trofin
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move register allocation unittests and constrain owners There are subtle test expectations/nuances that are easy to break. BUG= Review-Url: https://codereview.chromium.org/2585583006 Cr-Commit-Position: refs/heads/master@{#41778} Committed: https://chromium.googlesource.com/v8/v8/+/9564d803eaa054048e066d6d1c5dd41ef9c113bc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1775 lines) Patch
M test/unittests/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
D test/unittests/compiler/live-range-unittest.cc View 1 chunk +0 lines, -464 lines 0 comments Download
D test/unittests/compiler/move-optimizer-unittest.cc View 1 chunk +0 lines, -439 lines 0 comments Download
A test/unittests/compiler/regalloc/OWNERS View 1 chunk +5 lines, -0 lines 0 comments Download
A + test/unittests/compiler/regalloc/live-range-unittest.cc View 24 chunks +0 lines, -30 lines 0 comments Download
A + test/unittests/compiler/regalloc/move-optimizer-unittest.cc View 8 chunks +0 lines, -8 lines 0 comments Download
A + test/unittests/compiler/regalloc/register-allocator-unittest.cc View 29 chunks +0 lines, -30 lines 0 comments Download
D test/unittests/compiler/register-allocator-unittest.cc View 1 chunk +0 lines, -798 lines 0 comments Download
M test/unittests/unittests.gyp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
Mircea Trofin
4 years ago (2016-12-16 23:45:02 UTC) #6
bradnelson
lgtm Maybe describe the motivation for narrowing the set of folks?
4 years ago (2016-12-17 00:20:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2585583006/1
4 years ago (2016-12-17 00:23:01 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-17 00:24:44 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/9564d803eaa054048e066d6d1c5dd41ef9c...

Powered by Google App Engine
This is Rietveld 408576698