Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 2585533002: MediaRecorder (cleanup): support mime type video/x-matroska and codec=avc1 to the list (Closed)

Created:
4 years ago by mcasas
Modified:
4 years ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, emircan+watch+mediarecorder_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch+mediarecorder_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MediaRecorder (cleanup): support mime type video/x-matroska and codec=avc1 to the list Following some recommendations in the spec [1] and [2], this CL adds "video/x-matroska;codecs=avc1" and "video/webm;codecs=avc1" to the supported list, reusing the existing H264 encode path. [1] https://github.com/w3c/mediacapture-record/issues/93 [2] https://github.com/w3c/mediacapture-record/issues/94 BUG= Committed: https://crrev.com/0ec3cc16848b557d9132b9b2ec7d4410fd0f404a Cr-Commit-Position: refs/heads/master@{#439002}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -19 lines) Patch
M content/browser/webrtc/webrtc_media_recorder_browsertest.cc View 4 chunks +9 lines, -7 lines 0 comments Download
M content/renderer/media/media_recorder_handler.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M content/test/data/media/mediarecorder_test.html View 4 chunks +6 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/mediarecorder/MediaRecorder-isTypeSupported.html View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
mcasas
emircan@ ptal
4 years ago (2016-12-15 22:46:51 UTC) #3
emircan
lgtm
4 years ago (2016-12-16 00:47:43 UTC) #8
mcasas
avi@ RS plz content/...browsertest.cc changes plz.
4 years ago (2016-12-16 00:57:19 UTC) #10
Avi (use Gerrit)
lgtm stampity stamp
4 years ago (2016-12-16 01:48:30 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2585533002/1
4 years ago (2016-12-16 01:51:54 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-16 03:36:02 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-16 03:40:38 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0ec3cc16848b557d9132b9b2ec7d4410fd0f404a
Cr-Commit-Position: refs/heads/master@{#439002}

Powered by Google App Engine
This is Rietveld 408576698