Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2585473003:
Roll clang 289575:289864. (Closed)
|
Created:
4 years ago by hans Modified:
4 years ago Reviewers:
Nico CC:
chromium-reviews, eugenis+clang_chromium.org, vmpstr+watch_chromium.org, Lei Zhang, dsinclair, yunlian, glider+clang_chromium.org, ukai+watch_chromium.org, Reid Kleckner, dmikurube+clang_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRoll clang 289575:289864.
Ran `tools/clang/scripts/upload_revision.py 289864`.
BUG=674274
Committed: https://crrev.com/ecd7aefbeb1138d1bff9302f8061e28a058d8ac1
Cr-Commit-Position: refs/heads/master@{#439049}
Patch Set 1 #
Messages
Total messages: 26 (14 generated)
The CQ bit was checked by hans@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
hans@chromium.org changed reviewers: + thakis@chromium.org
I'll be afk for about an hour. If the bots look good, feel free to cq.
lgtm Looks good so far, but I'll wait a bit longer for more results before hitting cq.
On 2016/12/16 01:06:19, Nico (out Thu Dec 15) wrote: > lgtm > > Looks good so far, but I'll wait a bit longer for more results before hitting > cq. mac_chromium_asan_rel_ng failed, but only with a single test: https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_asa... wdyt?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
On 2016/12/16 01:32:57, hans wrote: > On 2016/12/16 01:06:19, Nico (out Thu Dec 15) wrote: > > lgtm > > > > Looks good so far, but I'll wait a bit longer for more results before hitting > > cq. > > mac_chromium_asan_rel_ng failed, but only with a single test: > https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_asa... > > wdyt? I saw that earlier; I think it's ok. Even if it's not a flake, we can disable that one test for a while.
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
mac asan came back green on second try, linux msan came back green. I think this is good for cq.
The CQ bit was unchecked by thakis@chromium.org
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/12/16 04:49:09, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) The previous, purple, linux_chromium_asan_rel_ng jobs passed the compile step, so that looks like a flake.
It's the bot timeout: The bots timeout after 2h or 2h15m, and with an empty goma cache (eg after a clang roll), it needs a few builds for the cache to get full enough that compiles are fast enough to make it in under the timeout. We should probably raise that timeout :-/ On Thu, Dec 15, 2016 at 11:55 PM, <hans@chromium.org> wrote: > On 2016/12/16 04:49:09, commit-bot: I haz the power wrote: > > Try jobs failed on following builders: > > linux_chromium_asan_rel_ng on master.tryserver.chromium.linux > (JOB_FAILED, > > > http://build.chromium.org/p/tryserver.chromium.linux/ > builders/linux_chromium_asan_rel_ng/builds/280799) > > The previous, purple, linux_chromium_asan_rel_ng jobs passed the compile > step, > so that looks like a flake. > > https://codereview.chromium.org/2585473003/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481863783115110, "parent_rev":
"d84f2c117bcd96bd05bde26d06974fa471b33e8b", "commit_rev":
"19d22aa70bc7b4e0bc4c44979552cdf7aa17a1fc"}
Message was sent while issue was closed.
Description was changed from ========== Roll clang 289575:289864. Ran `tools/clang/scripts/upload_revision.py 289864`. BUG=674274 ========== to ========== Roll clang 289575:289864. Ran `tools/clang/scripts/upload_revision.py 289864`. BUG=674274 Review-Url: https://codereview.chromium.org/2585473003 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Roll clang 289575:289864. Ran `tools/clang/scripts/upload_revision.py 289864`. BUG=674274 Review-Url: https://codereview.chromium.org/2585473003 ========== to ========== Roll clang 289575:289864. Ran `tools/clang/scripts/upload_revision.py 289864`. BUG=674274 Committed: https://crrev.com/ecd7aefbeb1138d1bff9302f8061e28a058d8ac1 Cr-Commit-Position: refs/heads/master@{#439049} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/ecd7aefbeb1138d1bff9302f8061e28a058d8ac1 Cr-Commit-Position: refs/heads/master@{#439049} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
