Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(952)

Issue 2585473002: chromeos: Avoid crash on thaw failure if freezing failed. (Closed)

Created:
4 years ago by Daniel Erat
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

chromeos: Avoid crash on thaw failure if freezing failed. Avoid an "Unable to thaw renderers." LOG(FATAL) in RendererFreezer if freezing the renderers also failed earlier. This is a workaround for unexplained EBADF and ENOENT errors seen when writing to cgroups. BUG=chromium:661310 TEST=manual: log in and chmod freezer.state in /sys/fs/cgroup/freezer/chrome_renderers/to_be_frozen to 444; suspend and resume and check that chrome doesn't abort Review-Url: https://codereview.chromium.org/2575933002 Cr-Commit-Position: refs/heads/master@{#438625} (cherry picked from commit d66436c2b7a48ae82eda1af894fa79b81a5ffaad) Committed: https://chromium.googlesource.com/chromium/src/+/f0bf44baaa4b984dd3512d4f9565232919c69637

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M chrome/browser/chromeos/power/freezer_cgroup_process_manager.cc View 4 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Daniel Erat
4 years ago (2016-12-15 19:03:18 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f0bf44baaa4b984dd3512d4f9565232919c69637.

Powered by Google App Engine
This is Rietveld 408576698