Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2575933002: chromeos: Avoid crash on thaw failure if freezing failed. (Closed)

Created:
4 years ago by Daniel Erat
Modified:
4 years ago
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: Avoid crash on thaw failure if freezing failed. Avoid an "Unable to thaw renderers." LOG(FATAL) in RendererFreezer if freezing the renderers also failed earlier. This is a workaround for unexplained EBADF and ENOENT errors seen when writing to cgroups. BUG=chromium:661310 TEST=manual: log in and chmod freezer.state in /sys/fs/cgroup/freezer/chrome_renderers/to_be_frozen to 444; suspend and resume and check that chrome doesn't abort Committed: https://crrev.com/d66436c2b7a48ae82eda1af894fa79b81a5ffaad Cr-Commit-Position: refs/heads/master@{#438625}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M chrome/browser/chromeos/power/freezer_cgroup_process_manager.cc View 4 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Daniel Erat
4 years ago (2016-12-14 18:51:04 UTC) #2
chirantan
lgtm Thanks!
4 years ago (2016-12-14 18:55:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2575933002/1
4 years ago (2016-12-14 21:10:42 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-14 21:19:44 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-14 21:22:57 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d66436c2b7a48ae82eda1af894fa79b81a5ffaad
Cr-Commit-Position: refs/heads/master@{#438625}

Powered by Google App Engine
This is Rietveld 408576698