Disable two plugin power saver tests on macOS.

Disable two plugin power saver tests on macOS.

The tests fail on macOS 10.12 and need to be investigated by the PPS team.

BUG=599484, 665691
Committed: https://crrev.com/fde5cb085de250b5ac8b96ff8f95e1d54038ae2d
Cr-Commit-Position: refs/heads/master@{#439218}

[erikchen, 2016-12-15 18:53:01]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 18:53:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 19:25:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 19:25:29]

Dry run: This issue passed the CQ dry run.

[erikchen, 2016-12-15 20:09:54]

erikchen@chromium.org changed reviewers:
+ sky@chromium.org, tommycli@chromium.org

[erikchen, 2016-12-15 20:09:55]

sky: Please review.

[tommycli, 2016-12-15 20:32:36]

https://codereview.chromium.org/2585433002/diff/1/chrome/browser/plugins/plug...
File chrome/browser/plugins/plugin_power_saver_browsertest.cc (left):

https://codereview.chromium.org/2585433002/diff/1/chrome/browser/plugins/plug...
chrome/browser/plugins/plugin_power_saver_browsertest.cc:385: bool
PixelTestsEnabled() {
Can you disable the test here? (i.e. does disabling the pixel tests portion of
this browser test fix the issue?)

[erikchen, 2016-12-16 19:01:20]

On 2016/12/15 20:32:36, tommycli wrote:
>
https://codereview.chromium.org/2585433002/diff/1/chrome/browser/plugins/plug...
> File chrome/browser/plugins/plugin_power_saver_browsertest.cc (left):
> 
>
https://codereview.chromium.org/2585433002/diff/1/chrome/browser/plugins/plug...
> chrome/browser/plugins/plugin_power_saver_browsertest.cc:385: bool
> PixelTestsEnabled() {
> Can you disable the test here? (i.e. does disabling the pixel tests portion of
> this browser test fix the issue?)

One of the failures appears related to pixel tests, the other does not. I'd
prefer to shut off both tests and let someone from PPS investigate further:
https://bugs.chromium.org/p/chromium/issues/detail?id=599484#c23

[tommycli, 2016-12-16 19:10:13]

On 2016/12/16 19:01:20, erikchen wrote:
> On 2016/12/15 20:32:36, tommycli wrote:
> >
>
https://codereview.chromium.org/2585433002/diff/1/chrome/browser/plugins/plug...
> > File chrome/browser/plugins/plugin_power_saver_browsertest.cc (left):
> > 
> >
>
https://codereview.chromium.org/2585433002/diff/1/chrome/browser/plugins/plug...
> > chrome/browser/plugins/plugin_power_saver_browsertest.cc:385: bool
> > PixelTestsEnabled() {
> > Can you disable the test here? (i.e. does disabling the pixel tests portion
of
> > this browser test fix the issue?)
> 
> One of the failures appears related to pixel tests, the other does not. I'd
> prefer to shut off both tests and let someone from PPS investigate further:
> https://bugs.chromium.org/p/chromium/issues/detail?id=599484#c23

Erik: Thank you for the due diligence. Feel free to shut off both tests. LGTM

[tommycli, 2016-12-16 19:11:02]

On 2016/12/16 19:10:13, tommycli wrote:
> On 2016/12/16 19:01:20, erikchen wrote:
> > On 2016/12/15 20:32:36, tommycli wrote:
> > >
> >
>
https://codereview.chromium.org/2585433002/diff/1/chrome/browser/plugins/plug...
> > > File chrome/browser/plugins/plugin_power_saver_browsertest.cc (left):
> > > 
> > >
> >
>
https://codereview.chromium.org/2585433002/diff/1/chrome/browser/plugins/plug...
> > > chrome/browser/plugins/plugin_power_saver_browsertest.cc:385: bool
> > > PixelTestsEnabled() {
> > > Can you disable the test here? (i.e. does disabling the pixel tests
portion
> of
> > > this browser test fix the issue?)
> > 
> > One of the failures appears related to pixel tests, the other does not. I'd
> > prefer to shut off both tests and let someone from PPS investigate further:
> > https://bugs.chromium.org/p/chromium/issues/detail?id=599484#c23
> 
> Erik: Thank you for the due diligence. Feel free to shut off both tests. LGTM

btw, I think I'm an owner of that file, so I think you only need my stamp

[erikchen, 2016-12-16 19:11:55]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2016-12-16 19:12:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 22:29:35]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481915515951140, "parent_rev":
"8ad64bf9e8dd639e5439a3acffef0a19e6c472b5", "commit_rev":
"75c333c2b1ffd8ccde2dd30e0ce2a0b47cb6f9ec"}

[commit-bot: I haz the power, 2016-12-16 22:30:02]

Description was changed from

==========
Disable two plugin power saver tests on macOS.

The tests fail on macOS 10.12 and need to be investigated by the PPS team.

BUG=599484, 665691
==========

to

==========
Disable two plugin power saver tests on macOS.

The tests fail on macOS 10.12 and need to be investigated by the PPS team.

BUG=599484, 665691

Review-Url: https://codereview.chromium.org/2585433002
==========

[commit-bot: I haz the power, 2016-12-16 22:30:03]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-16 22:31:42]

Description was changed from

==========
Disable two plugin power saver tests on macOS.

The tests fail on macOS 10.12 and need to be investigated by the PPS team.

BUG=599484, 665691

Review-Url: https://codereview.chromium.org/2585433002
==========

to

==========
Disable two plugin power saver tests on macOS.

The tests fail on macOS 10.12 and need to be investigated by the PPS team.

BUG=599484, 665691

Committed: https://crrev.com/fde5cb085de250b5ac8b96ff8f95e1d54038ae2d
Cr-Commit-Position: refs/heads/master@{#439218}
==========

[commit-bot: I haz the power, 2016-12-16 22:31:43]

Patchset 1 (id:??) landed as
https://crrev.com/fde5cb085de250b5ac8b96ff8f95e1d54038ae2d
Cr-Commit-Position: refs/heads/master@{#439218}