DevTools: [Persistence] implement Persistence.subscribeForBindingEvents

DevTools: [Persistence] implement Persistence.subscribeForBindingEvents

This patch implements per-uiSourceCode subscriptions for binding events.
They allow clients to subscribe to binding status changes of a particular
UISourceCode. This makes event delivery much more efficient.

BUG=649837
R=dgozman

Committed: https://crrev.com/095e1c0df2e2cac1d869127f83fce8c0afdadd37
Cr-Commit-Position: refs/heads/master@{#439972}

[lushnikov, 2016-12-20 02:47:20]

Description was changed from

==========
DevTools: [Persistence] implement Persistence.subscribeForBindingEvents method

This patch implements subscribeForBindingEvents/unsubscribeFromBindingEvents
persistence methods. They allow clients to subscribe about binding
status of a particular UISourceCode. This makes event delivery much
more efficient.

BUG=649837
R=dgozman
==========

to

==========
DevTools: [Persistence] implement Persistence.subscribeForBindingEvents

This patch implements per-uiSourceCode subscriptions for binding events.
They allow clients to subscribe to binding status changes of a particular
UISourceCode. This makes event delivery much more efficient.

BUG=649837
R=dgozman
==========

[lushnikov, 2016-12-20 02:50:02]

please, take a look

https://codereview.chromium.org/2585393003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js
(right):

https://codereview.chromium.org/2585393003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js:282:
subscribeForBindingEvent(uiSourceCode, listener, thisObject) {
I called this "subscribeForBindingEvent" rather then
"subscribeForBindingChanged", because I'm about to add a third binding event,
BindingFailed. It will be needed to display the red-glowing icon when the
network content mismatched the file content.

[lushnikov, 2016-12-20 02:50:19]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 02:50:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 04:02:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 04:02:17]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dgozman, 2016-12-20 05:47:03]

lgtm

https://codereview.chromium.org/2585393003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js
(right):

https://codereview.chromium.org/2585393003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js:282:
subscribeForBindingEvent(uiSourceCode, listener, thisObject) {
Let's not support thisObject - this will make code easier.

https://codereview.chromium.org/2585393003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js:291:
unsubscribeFromBindingEvent(uiSourceCode, listener) {
... otherwise you have to pass thisObject here as well.

https://codereview.chromium.org/2585393003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js:306:
listener.call(listener[Persistence.Persistence._listenerReciever],
uiSourceCode);
Declared listener type doesn't take UISourceCode as a parameter.

[lushnikov, 2016-12-20 18:38:35]

https://codereview.chromium.org/2585393003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js
(right):

https://codereview.chromium.org/2585393003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js:282:
subscribeForBindingEvent(uiSourceCode, listener, thisObject) {
On 2016/12/20 05:47:03, dgozman wrote:
> Let's not support thisObject - this will make code easier.

Done.

https://codereview.chromium.org/2585393003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js:291:
unsubscribeFromBindingEvent(uiSourceCode, listener) {
On 2016/12/20 05:47:03, dgozman wrote:
> ... otherwise you have to pass thisObject here as well.

Done.

https://codereview.chromium.org/2585393003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js:306:
listener.call(listener[Persistence.Persistence._listenerReciever],
uiSourceCode);
On 2016/12/20 05:47:03, dgozman wrote:
> Declared listener type doesn't take UISourceCode as a parameter.

Done.

[lushnikov, 2016-12-20 18:38:38]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2016-12-20 18:38:39]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2585393003/#ps40001
(title: "address comments")

[commit-bot: I haz the power, 2016-12-20 18:39:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 21:47:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 21:47:43]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[lushnikov, 2016-12-21 00:21:11]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2016-12-21 00:21:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 01:49:56]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1482279671532190,
"parent_rev": "74a1b926f34bccc6cb3b84d7854860b9b9108edc", "commit_rev":
"73d9e87554a558a2ba9986be447772463b615234"}

[commit-bot: I haz the power, 2016-12-21 01:50:25]

Description was changed from

==========
DevTools: [Persistence] implement Persistence.subscribeForBindingEvents

This patch implements per-uiSourceCode subscriptions for binding events.
They allow clients to subscribe to binding status changes of a particular
UISourceCode. This makes event delivery much more efficient.

BUG=649837
R=dgozman
==========

to

==========
DevTools: [Persistence] implement Persistence.subscribeForBindingEvents

This patch implements per-uiSourceCode subscriptions for binding events.
They allow clients to subscribe to binding status changes of a particular
UISourceCode. This makes event delivery much more efficient.

BUG=649837
R=dgozman

Review-Url: https://codereview.chromium.org/2585393003
==========

[commit-bot: I haz the power, 2016-12-21 01:50:28]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-21 01:51:59]

Description was changed from

==========
DevTools: [Persistence] implement Persistence.subscribeForBindingEvents

This patch implements per-uiSourceCode subscriptions for binding events.
They allow clients to subscribe to binding status changes of a particular
UISourceCode. This makes event delivery much more efficient.

BUG=649837
R=dgozman

Review-Url: https://codereview.chromium.org/2585393003
==========

to

==========
DevTools: [Persistence] implement Persistence.subscribeForBindingEvents

This patch implements per-uiSourceCode subscriptions for binding events.
They allow clients to subscribe to binding status changes of a particular
UISourceCode. This makes event delivery much more efficient.

BUG=649837
R=dgozman

Committed: https://crrev.com/095e1c0df2e2cac1d869127f83fce8c0afdadd37
Cr-Commit-Position: refs/heads/master@{#439972}
==========

[commit-bot: I haz the power, 2016-12-21 01:52:00]

Patchset 3 (id:??) landed as
https://crrev.com/095e1c0df2e2cac1d869127f83fce8c0afdadd37
Cr-Commit-Position: refs/heads/master@{#439972}