Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2585383002:
Fix low frame rate problems in high resolution USB cameras using AVFoundation (Closed)
|
Created:
4 years ago by emircan Modified:
4 years ago Reviewers:
mcasas CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, mcasas+watch+vc_chromium.org, mac-reviews_chromium.org, xjz+watch_chromium.org, miu+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix low frame rate problems in high resolution USB cameras using AVFoundation
This CL addresses the issue reported in the below CL about low frame rate in high
resolution USB cameras using AVFoundation. It reorders output formats for
AVCaptureSession.
All credit for this patch goes to briely.marum@coviu.com, see
https://bugs.chromium.org/p/chromium/issues/detail?id=670944#c23
BUG=670944
TEST=Tested video output with C920.
Committed: https://crrev.com/c2df103047f0246c7a909544112c76627e0359e8
Cr-Commit-Position: refs/heads/master@{#439602}
Patch Set 1 #
Messages
Total messages: 18 (13 generated)
The CQ bit was checked by emircan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Stutter fix. BUG= ========== to ========== Fix low frame rate problems in high resolution USB cameras using AVFoundation This CL addresses the issue reported in the below CL about low frame rate in high resolution USB cameras using AVFoundation. It reorders output formats to All credit for this patch goes to briely.marum@coviu.com, see https://bugs.chromium.org/p/chromium/issues/detail?id=670944#c23 BUG=670944 TEST=Tested video output with C920. ==========
emircan@chromium.org changed reviewers: + mcasas@chromium.org
Description was changed from ========== Fix low frame rate problems in high resolution USB cameras using AVFoundation This CL addresses the issue reported in the below CL about low frame rate in high resolution USB cameras using AVFoundation. It reorders output formats to All credit for this patch goes to briely.marum@coviu.com, see https://bugs.chromium.org/p/chromium/issues/detail?id=670944#c23 BUG=670944 TEST=Tested video output with C920. ========== to ========== Fix low frame rate problems in high resolution USB cameras using AVFoundation This CL addresses the issue reported in the below CL about low frame rate in high resolution USB cameras using AVFoundation. It reorders output formats for AVCaptureSession. All credit for this patch goes to briely.marum@coviu.com, see https://bugs.chromium.org/p/chromium/issues/detail?id=670944#c23 BUG=670944 TEST=Tested video output with C920. ==========
PTAL.
rs lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by emircan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1482187675427920, "parent_rev":
"51384b12b0a041208116cb5762a95eed1bd7a10c", "commit_rev":
"7866f6af1522890499a9b9523a0a2dccf668d8bc"}
Message was sent while issue was closed.
Description was changed from ========== Fix low frame rate problems in high resolution USB cameras using AVFoundation This CL addresses the issue reported in the below CL about low frame rate in high resolution USB cameras using AVFoundation. It reorders output formats for AVCaptureSession. All credit for this patch goes to briely.marum@coviu.com, see https://bugs.chromium.org/p/chromium/issues/detail?id=670944#c23 BUG=670944 TEST=Tested video output with C920. ========== to ========== Fix low frame rate problems in high resolution USB cameras using AVFoundation This CL addresses the issue reported in the below CL about low frame rate in high resolution USB cameras using AVFoundation. It reorders output formats for AVCaptureSession. All credit for this patch goes to briely.marum@coviu.com, see https://bugs.chromium.org/p/chromium/issues/detail?id=670944#c23 BUG=670944 TEST=Tested video output with C920. Review-Url: https://codereview.chromium.org/2585383002 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Fix low frame rate problems in high resolution USB cameras using AVFoundation This CL addresses the issue reported in the below CL about low frame rate in high resolution USB cameras using AVFoundation. It reorders output formats for AVCaptureSession. All credit for this patch goes to briely.marum@coviu.com, see https://bugs.chromium.org/p/chromium/issues/detail?id=670944#c23 BUG=670944 TEST=Tested video output with C920. Review-Url: https://codereview.chromium.org/2585383002 ========== to ========== Fix low frame rate problems in high resolution USB cameras using AVFoundation This CL addresses the issue reported in the below CL about low frame rate in high resolution USB cameras using AVFoundation. It reorders output formats for AVCaptureSession. All credit for this patch goes to briely.marum@coviu.com, see https://bugs.chromium.org/p/chromium/issues/detail?id=670944#c23 BUG=670944 TEST=Tested video output with C920. Committed: https://crrev.com/c2df103047f0246c7a909544112c76627e0359e8 Cr-Commit-Position: refs/heads/master@{#439602} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/c2df103047f0246c7a909544112c76627e0359e8 Cr-Commit-Position: refs/heads/master@{#439602}
Message was sent while issue was closed.
Description was changed from ========== Fix low frame rate problems in high resolution USB cameras using AVFoundation This CL addresses the issue reported in the below CL about low frame rate in high resolution USB cameras using AVFoundation. It reorders output formats for AVCaptureSession. All credit for this patch goes to briely.marum@coviu.com, see https://bugs.chromium.org/p/chromium/issues/detail?id=670944#c23 BUG=670944 TEST=Tested video output with C920. Committed: https://crrev.com/c2df103047f0246c7a909544112c76627e0359e8 Cr-Commit-Position: refs/heads/master@{#439602} ========== to ========== Merge 56: Fix low frame rate problems in high resolution USB cameras using AVFoundation This CL addresses the issue reported in the below CL about low frame rate in high resolution USB cameras using AVFoundation. It reorders output formats for AVCaptureSession. All credit for this patch goes to briely.marum@coviu.com, see https://bugs.chromium.org/p/chromium/issues/detail?id=670944#c23 BUG=670944 TEST=Tested video output with C920. Committed: https://crrev.com/c2df103047f0246c7a909544112c76627e0359e8 Cr-Commit-Position: refs/heads/master@{#439602} NOTRY=true NOPRESUBMIT=true TBR=mcasas@chromium.org ==========
Message was sent while issue was closed.
Description was changed from ========== Merge 56: Fix low frame rate problems in high resolution USB cameras using AVFoundation This CL addresses the issue reported in the below CL about low frame rate in high resolution USB cameras using AVFoundation. It reorders output formats for AVCaptureSession. All credit for this patch goes to briely.marum@coviu.com, see https://bugs.chromium.org/p/chromium/issues/detail?id=670944#c23 BUG=670944 TEST=Tested video output with C920. Committed: https://crrev.com/c2df103047f0246c7a909544112c76627e0359e8 Cr-Commit-Position: refs/heads/master@{#439602} NOTRY=true NOPRESUBMIT=true TBR=mcasas@chromium.org ========== to ========== Fix low frame rate problems in high resolution USB cameras using AVFoundation This CL addresses the issue reported in the below CL about low frame rate in high resolution USB cameras using AVFoundation. It reorders output formats for AVCaptureSession. All credit for this patch goes to briely.marum@coviu.com, see https://bugs.chromium.org/p/chromium/issues/detail?id=670944#c23 BUG=670944 TEST=Tested video output with C920. Committed: https://crrev.com/c2df103047f0246c7a909544112c76627e0359e8 Cr-Commit-Position: refs/heads/master@{#439602} ========== |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
