Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issue 2585293003: Clean up in iOS code coverage code. (Closed)

Created:
4 years ago by lpromero
Modified:
4 years ago
CC:
chromium-reviews, mac-reviews_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up in iOS code coverage code. BUG=none R=eugenebut@chromium.org Committed: https://crrev.com/b51cebf1e32548a16de9f27fa09f6e91ad6c1576 Cr-Commit-Position: refs/heads/master@{#439563}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M base/test/test_support_ios.mm View 4 chunks +8 lines, -9 lines 0 comments Download
M testing/coverage_util_ios.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
lpromero
4 years ago (2016-12-19 17:17:30 UTC) #1
lpromero
A few things I picked up while investigating.
4 years ago (2016-12-19 17:17:49 UTC) #3
Eugene But (OOO till 7-30)
Thank you for cleanup!
4 years ago (2016-12-19 17:32:11 UTC) #5
Eugene But (OOO till 7-30)
lgtm
4 years ago (2016-12-19 17:32:17 UTC) #6
lpromero
phajdan.jr@chromium.org: Please review changes in both files.
4 years ago (2016-12-19 17:33:43 UTC) #8
Paweł Hajdan Jr.
LGTM
4 years ago (2016-12-19 18:56:30 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2585293003/1
4 years ago (2016-12-19 21:08:15 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-19 21:18:40 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-19 21:21:29 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b51cebf1e32548a16de9f27fa09f6e91ad6c1576
Cr-Commit-Position: refs/heads/master@{#439563}

Powered by Google App Engine
This is Rietveld 408576698