Integration of PasswordReuseDetector into PasswordStore.

chrome/browser/password_manager/chrome_password_manager_client.cc

Index: chrome/browser/password_manager/chrome_password_manager_client.cc
diff --git a/chrome/browser/password_manager/chrome_password_manager_client.cc b/chrome/browser/password_manager/chrome_password_manager_client.cc
index 22a725914159216f6c6a9283a9d582b5faec9ce6..3f3dca9b1cd0a67a57b6a3a90a6ec2583dd9174b 100644
--- a/chrome/browser/password_manager/chrome_password_manager_client.cc
+++ b/chrome/browser/password_manager/chrome_password_manager_client.cc
@@ -377,6 +377,13 @@ void ChromePasswordManagerClient::HidePasswordGenerationPopup() {
     popup_controller_->HideAndDestroy();
 }
 
+void ChromePasswordManagerClient::CheckReuse(
+    const base::string16& input,
+    const std::string& domain,
+    password_manager::PasswordReuseDetectorConsumer* consumer) {
+  GetPasswordStore()->CheckReuse(input, domain, consumer);

[vabr (Chromium), 2016/12/20 18:11:44]

What is the advantage of having PasswordManagerClient::CheckReuse over all the
callsites just using the client's already existing GetPasswordStore() to call
CheckReuse directly on the store?

[dvadym, 2016/12/21 12:15:35]

Mainly for easier testing. In the next CL I'm going to use mock for this method
for checking that it's fired. But if you think that it's better to call
PasswordStore.CheckReuse. But you are right, probably these methods in the
client could be unnessary. I've removed client changes from this CL and if
needed I'll add them later.

+}
+
 PrefService* ChromePasswordManagerClient::GetPrefs() {
   return profile_->GetPrefs();
 }