Integration of PasswordReuseDetector into PasswordStore.

chrome/browser/password_manager/chrome_password_manager_client.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/password_manager/chrome_password_manager_client.h"
 
 #include <string>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 359 matching lines @@
   manage_passwords_ui_controller->OnPasswordAutofilled(best_matches, origin,
                                                        federated_matches);
 #endif
 }
 
 void ChromePasswordManagerClient::HidePasswordGenerationPopup() {
   if (popup_controller_)
     popup_controller_->HideAndDestroy();
 }
 
+void ChromePasswordManagerClient::CheckReuse(
+    const base::string16& input,
+    const std::string& domain,
+    password_manager::PasswordReuseDetectorConsumer* consumer) {
+  GetPasswordStore()->CheckReuse(input, domain, consumer);

[vabr (Chromium), 2016/12/20 18:11:44]

What is the advantage of having PasswordManagerClient::CheckReuse over all the
callsites just using the client's already existing GetPasswordStore() to call
CheckReuse directly on the store?

[dvadym, 2016/12/21 12:15:35]

Mainly for easier testing. In the next CL I'm going to use mock for this method
for checking that it's fired. But if you think that it's better to call
PasswordStore.CheckReuse. But you are right, probably these methods in the
client could be unnessary. I've removed client changes from this CL and if
needed I'll add them later.

+}
+
 PrefService* ChromePasswordManagerClient::GetPrefs() {
   return profile_->GetPrefs();
 }
 
 password_manager::PasswordStore*
 ChromePasswordManagerClient::GetPasswordStore() const {
   // Always use EXPLICIT_ACCESS as the password manager checks IsOffTheRecord
   // itself when it shouldn't access the PasswordStore.
   // TODO(gcasto): Is is safe to change this to
   // ServiceAccessType::IMPLICIT_ACCESS?
@@ skipping 223 matching lines @@
       ChromePasswordManagerClient::FromWebContents(web_contents);
 
   // Try to bind to the driver, but if driver is not available for this render
   // frame host, the request will be just dropped. This will cause the message
   // pipe to be closed, which will raise a connection error on the peer side.
   if (!instance)
     return;
 
   instance->credential_manager_impl_.BindRequest(std::move(request));
 }