Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 2585243002: [MediaSession] A fix for MediaSessionService routing (Closed)

Created:
4 years ago by Zhiqiang Zhang (Slow)
Modified:
4 years ago
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MediaSession] A fix for MediaSessionService routing Previously, MediaSessionImpl uses the metadata and controls to determine whether a page uses the MediaSession API. However there comes an issues that we need to update the routed MediaSession every time when a service is created/destroyed or its metadata/controls changed, which is a lot of maintainance work. This CL simplifies the MediaSessionService routing strategy. It only checks whether a service is created for a given frame. The rationale is that a MediaSessionService is created when and only when anything passes through mojo, which is enough for indicating whether a frame uses MediaSession API. BUG=670319 Committed: https://crrev.com/7f5596e8dcfd88ba7700393dd937eafb9ea39167 Cr-Commit-Position: refs/heads/master@{#439488}

Patch Set 1 #

Patch Set 2 : fixed compile warning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -14 lines) Patch
M content/browser/media/session/media_session_impl.cc View 1 2 chunks +2 lines, -5 lines 0 comments Download
M content/browser/media/session/media_session_impl_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/media/session/media_session_impl_service_routing_unittest.cc View 2 chunks +25 lines, -8 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Zhiqiang Zhang (Slow)
PTAL :) Found this issue when working on the playbackState.
4 years ago (2016-12-19 11:58:03 UTC) #2
mlamouri (slow - plz ping)
lgtm
4 years ago (2016-12-19 12:20:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2585243002/20001
4 years ago (2016-12-19 14:11:38 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-19 16:28:24 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-19 16:31:52 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7f5596e8dcfd88ba7700393dd937eafb9ea39167
Cr-Commit-Position: refs/heads/master@{#439488}

Powered by Google App Engine
This is Rietveld 408576698