Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2585233003: Upstream Chrome on iOS source code [2/11]. (Closed)

Created:
4 years ago by sdefresne
Modified:
4 years ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, vabr+watchlistpasswordmanager_chromium.org, mlamouri+watch-geolocation_chromium.org, pkl (ping after 24h if needed), asvitkine+watch_chromium.org, Michael van Ouwerkerk, gcasto+watchlist_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream Chrome on iOS source code [2/11]. Upstream part of Chrome on iOS source code. Nothing is build yet, just new files added. The file will be added to the build as part of the last CL to avoid breaking downstream tree. BUG=653086 Committed: https://crrev.com/67dfdd6846a48ab001e262bcce04345a7ceb97d0 Cr-Commit-Position: refs/heads/master@{#439454}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19696 lines, -0 lines) Patch
A ios/chrome/browser/crash_report/crash_restore_helper.mm View 1 chunk +307 lines, -0 lines 0 comments Download
A ios/chrome/browser/crash_report/crash_restore_helper_unittest.mm View 1 chunk +75 lines, -0 lines 0 comments Download
A ios/chrome/browser/device_sharing/handoff_manager_egtest.mm View 1 chunk +145 lines, -0 lines 0 comments Download
A ios/chrome/browser/downstream_chromium_browser_provider.h View 1 chunk +47 lines, -0 lines 0 comments Download
A ios/chrome/browser/downstream_chromium_browser_provider.mm View 1 chunk +93 lines, -0 lines 0 comments Download
A ios/chrome/browser/downstream_chromium_browser_provider_factory.mm View 1 chunk +13 lines, -0 lines 0 comments Download
A ios/chrome/browser/geolocation/omnibox_geolocation_controller.h View 1 chunk +60 lines, -0 lines 0 comments Download
A ios/chrome/browser/geolocation/omnibox_geolocation_controller.mm View 1 chunk +586 lines, -0 lines 0 comments Download
A ios/chrome/browser/geolocation/omnibox_geolocation_controller+Testing.h View 1 chunk +24 lines, -0 lines 0 comments Download
A ios/chrome/browser/metrics/first_user_action_recorder.h View 1 chunk +94 lines, -0 lines 0 comments Download
A ios/chrome/browser/metrics/first_user_action_recorder.cc View 1 chunk +206 lines, -0 lines 0 comments Download
A ios/chrome/browser/metrics/first_user_action_recorder_unittest.cc View 1 chunk +151 lines, -0 lines 0 comments Download
A ios/chrome/browser/metrics/new_tab_page_uma.h View 1 chunk +36 lines, -0 lines 0 comments Download
A ios/chrome/browser/metrics/new_tab_page_uma.mm View 1 chunk +49 lines, -0 lines 0 comments Download
A ios/chrome/browser/metrics/size_class_recorder.h View 1 chunk +28 lines, -0 lines 0 comments Download
A ios/chrome/browser/metrics/size_class_recorder.mm View 1 chunk +134 lines, -0 lines 0 comments Download
A ios/chrome/browser/metrics/size_class_recorder_private.h View 1 chunk +25 lines, -0 lines 0 comments Download
A ios/chrome/browser/metrics/size_class_recorder_unittest.mm View 1 chunk +206 lines, -0 lines 0 comments Download
A ios/chrome/browser/metrics/tab_usage_recorder.h View 1 chunk +222 lines, -0 lines 0 comments Download
A ios/chrome/browser/metrics/tab_usage_recorder.mm View 1 chunk +336 lines, -0 lines 0 comments Download
A ios/chrome/browser/metrics/tab_usage_recorder_delegate.h View 1 chunk +21 lines, -0 lines 0 comments Download
A ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm View 1 chunk +956 lines, -0 lines 0 comments Download
A ios/chrome/browser/metrics/tab_usage_recorder_unittest.mm View 1 chunk +366 lines, -0 lines 0 comments Download
A ios/chrome/browser/native_app_launcher/native_app_navigation_controller.h View 1 chunk +34 lines, -0 lines 0 comments Download
A ios/chrome/browser/native_app_launcher/native_app_navigation_controller.mm View 1 chunk +247 lines, -0 lines 0 comments Download
A ios/chrome/browser/native_app_launcher/native_app_navigation_controller_unittest.mm View 1 chunk +176 lines, -0 lines 0 comments Download
A ios/chrome/browser/net/cookies_egtest.mm View 1 chunk +274 lines, -0 lines 0 comments Download
A ios/chrome/browser/passwords/password_generation_prompt_view.h View 1 chunk +34 lines, -0 lines 0 comments Download
A ios/chrome/browser/passwords/password_generation_prompt_view.mm View 1 chunk +397 lines, -0 lines 0 comments Download
A ios/chrome/browser/passwords/password_generation_prompt_view_controller.h View 1 chunk +29 lines, -0 lines 0 comments Download
A ios/chrome/browser/passwords/password_generation_prompt_view_controller.mm View 1 chunk +88 lines, -0 lines 0 comments Download
A ios/chrome/browser/passwords/passwords_ui_delegate_impl.h View 1 chunk +16 lines, -0 lines 0 comments Download
A ios/chrome/browser/passwords/passwords_ui_delegate_impl.mm View 1 chunk +66 lines, -0 lines 0 comments Download
A ios/chrome/browser/payments/cells/order_summary_line_item.h View 1 chunk +18 lines, -0 lines 0 comments Download
A ios/chrome/browser/payments/cells/order_summary_line_item.mm View 1 chunk +26 lines, -0 lines 0 comments Download
A ios/chrome/browser/payments/cells/order_summary_total_item.h View 1 chunk +18 lines, -0 lines 0 comments Download
A ios/chrome/browser/payments/cells/order_summary_total_item.mm View 1 chunk +26 lines, -0 lines 0 comments Download
A ios/chrome/browser/payments/cells/page_info_item.h View 1 chunk +44 lines, -0 lines 0 comments Download
A ios/chrome/browser/payments/cells/page_info_item.mm View 1 chunk +161 lines, -0 lines 0 comments Download
A ios/chrome/browser/payments/cells/page_info_item_unittest.mm View 1 chunk +44 lines, -0 lines 0 comments Download
A ios/chrome/browser/payments/cells/payment_method_item.h View 1 chunk +50 lines, -0 lines 0 comments Download
A ios/chrome/browser/payments/cells/payment_method_item.mm View 1 chunk +185 lines, -0 lines 0 comments Download
A ios/chrome/browser/payments/cells/payment_method_item_unittest.mm View 1 chunk +51 lines, -0 lines 0 comments Download
A ios/chrome/browser/payments/cells/shipping_address_item.h View 1 chunk +35 lines, -0 lines 0 comments Download
A ios/chrome/browser/payments/cells/shipping_address_item.mm View 1 chunk +191 lines, -0 lines 0 comments Download
A ios/chrome/browser/payments/js_payment_request_manager.h View 1 chunk +43 lines, -0 lines 0 comments Download
A ios/chrome/browser/payments/js_payment_request_manager.mm View 1 chunk +93 lines, -0 lines 0 comments Download
A ios/chrome/browser/payments/payment_items_display_coordinator.h View 1 chunk +51 lines, -0 lines 0 comments Download
A ios/chrome/browser/payments/payment_items_display_coordinator.mm View 1 chunk +65 lines, -0 lines 0 comments Download
A ios/chrome/browser/payments/payment_items_display_coordinator_unittest.mm View 1 chunk +41 lines, -0 lines 0 comments Download
A ios/chrome/browser/payments/payment_items_display_view_controller.h View 1 chunk +55 lines, -0 lines 0 comments Download
A ios/chrome/browser/payments/payment_items_display_view_controller.mm View 1 chunk +194 lines, -0 lines 0 comments Download
A ios/chrome/browser/payments/payment_items_display_view_controller_unittest.mm View 1 chunk +54 lines, -0 lines 0 comments Download
A ios/chrome/browser/payments/payment_method_selection_coordinator.h View 1 chunk +49 lines, -0 lines 0 comments Download
A ios/chrome/browser/payments/payment_method_selection_coordinator.mm View 1 chunk +66 lines, -0 lines 0 comments Download
A ios/chrome/browser/payments/payment_method_selection_view_controller.h View 1 chunk +53 lines, -0 lines 0 comments Download
A ios/chrome/browser/payments/payment_method_selection_view_controller.mm View 1 chunk +161 lines, -0 lines 0 comments Download
A ios/chrome/browser/payments/payment_request_coordinator.h View 1 chunk +77 lines, -0 lines 0 comments Download
A ios/chrome/browser/payments/payment_request_coordinator.mm View 1 chunk +284 lines, -0 lines 0 comments Download
A ios/chrome/browser/payments/payment_request_manager.h View 1 chunk +58 lines, -0 lines 0 comments Download
A ios/chrome/browser/payments/payment_request_manager.mm View 1 chunk +338 lines, -0 lines 0 comments Download
A ios/chrome/browser/payments/payment_request_utils.h View 1 chunk +21 lines, -0 lines 0 comments Download
A ios/chrome/browser/payments/payment_request_utils.mm View 1 chunk +29 lines, -0 lines 0 comments Download
A ios/chrome/browser/payments/payment_request_view_controller.h View 1 chunk +64 lines, -0 lines 0 comments Download
A ios/chrome/browser/payments/payment_request_view_controller.mm View 1 chunk +407 lines, -0 lines 0 comments Download
A ios/chrome/browser/payments/payment_request_web_state_observer.h View 1 chunk +33 lines, -0 lines 0 comments Download
A ios/chrome/browser/payments/payment_request_web_state_observer.mm View 1 chunk +22 lines, -0 lines 0 comments Download
A ios/chrome/browser/payments/shipping_address_selection_coordinator.h View 1 chunk +49 lines, -0 lines 0 comments Download
A ios/chrome/browser/payments/shipping_address_selection_coordinator.mm View 1 chunk +92 lines, -0 lines 0 comments Download
A ios/chrome/browser/payments/shipping_address_selection_coordinator_unittest.mm View 1 chunk +39 lines, -0 lines 0 comments Download
A ios/chrome/browser/payments/shipping_address_selection_view_controller.h View 1 chunk +54 lines, -0 lines 0 comments Download
A ios/chrome/browser/payments/shipping_address_selection_view_controller.mm View 1 chunk +185 lines, -0 lines 0 comments Download
A ios/chrome/browser/payments/shipping_address_selection_view_controller_unittest.mm View 1 chunk +63 lines, -0 lines 0 comments Download
A ios/chrome/browser/sessions/NSCoder+Compatibility.h View 1 chunk +25 lines, -0 lines 0 comments Download
A ios/chrome/browser/sessions/NSCoder+Compatibility.mm View 1 chunk +33 lines, -0 lines 0 comments Download
A ios/chrome/browser/sessions/session_service.h View 1 chunk +68 lines, -0 lines 0 comments Download
A ios/chrome/browser/sessions/session_service.mm View 1 chunk +251 lines, -0 lines 0 comments Download
A ios/chrome/browser/sessions/session_service_unittest.mm View 1 chunk +143 lines, -0 lines 0 comments Download
A ios/chrome/browser/sessions/session_util.h View 1 chunk +21 lines, -0 lines 0 comments Download
A ios/chrome/browser/sessions/session_util.mm View 1 chunk +22 lines, -0 lines 0 comments Download
A ios/chrome/browser/sessions/session_window.h View 1 chunk +41 lines, -0 lines 0 comments Download
A ios/chrome/browser/sessions/session_window.mm View 1 chunk +154 lines, -0 lines 0 comments Download
A ios/chrome/browser/sessions/session_window_unittest.mm View 1 chunk +125 lines, -0 lines 0 comments Download
A ios/chrome/browser/sessions/tab_restore_service_delegate_impl_ios.h View 1 chunk +71 lines, -0 lines 0 comments Download
A ios/chrome/browser/sessions/tab_restore_service_delegate_impl_ios.mm View 1 chunk +119 lines, -0 lines 0 comments Download
A ios/chrome/browser/sessions/tab_restore_service_delegate_impl_ios_factory.h View 1 chunk +46 lines, -0 lines 0 comments Download
A ios/chrome/browser/sessions/tab_restore_service_delegate_impl_ios_factory.mm View 1 chunk +43 lines, -0 lines 0 comments Download
A ios/chrome/browser/sessions/tab_restore_service_delegate_provider_impl.h View 1 chunk +26 lines, -0 lines 0 comments Download
A ios/chrome/browser/sessions/tab_restore_service_delegate_provider_impl.mm View 1 chunk +64 lines, -0 lines 0 comments Download
A ios/chrome/browser/sessions/test_session_service.h View 1 chunk +18 lines, -0 lines 0 comments Download
A ios/chrome/browser/sessions/test_session_service.mm View 1 chunk +13 lines, -0 lines 0 comments Download
A ios/chrome/browser/signin/signin_capability.h View 1 chunk +15 lines, -0 lines 0 comments Download
A ios/chrome/browser/signin/signin_capability.cc View 1 chunk +26 lines, -0 lines 0 comments Download
A ios/chrome/browser/snapshots/snapshot_overlay_provider.h View 1 chunk +22 lines, -0 lines 0 comments Download
A ios/chrome/browser/snapshots/web_controller_snapshot_helper.h View 1 chunk +76 lines, -0 lines 0 comments Download
A ios/chrome/browser/snapshots/web_controller_snapshot_helper.mm View 1 chunk +266 lines, -0 lines 0 comments Download
A ios/chrome/browser/tabs/tab.h View 1 chunk +354 lines, -0 lines 0 comments Download
A ios/chrome/browser/tabs/tab.mm View 1 chunk +2451 lines, -0 lines 0 comments Download
A ios/chrome/browser/tabs/tab_delegate.h View 1 chunk +18 lines, -0 lines 0 comments Download
A ios/chrome/browser/tabs/tab_dialog_delegate.h View 1 chunk +27 lines, -0 lines 0 comments Download
A ios/chrome/browser/tabs/tab_loading_delegate.h View 1 chunk +30 lines, -0 lines 0 comments Download
A ios/chrome/browser/tabs/tab_model.h View 1 chunk +323 lines, -0 lines 0 comments Download
A ios/chrome/browser/tabs/tab_model.mm View 1 chunk +1099 lines, -0 lines 0 comments Download
A ios/chrome/browser/tabs/tab_model_observer.h View 1 chunk +67 lines, -0 lines 0 comments Download
A ios/chrome/browser/tabs/tab_model_order_controller.h View 1 chunk +68 lines, -0 lines 0 comments Download
A ios/chrome/browser/tabs/tab_model_order_controller.mm View 1 chunk +104 lines, -0 lines 0 comments Download
A ios/chrome/browser/tabs/tab_model_order_controller_unittest.mm View 1 chunk +118 lines, -0 lines 0 comments Download
A ios/chrome/browser/tabs/tab_model_synced_window_delegate.h View 1 chunk +47 lines, -0 lines 0 comments Download
A ios/chrome/browser/tabs/tab_model_synced_window_delegate.mm View 1 chunk +78 lines, -0 lines 0 comments Download
A ios/chrome/browser/tabs/tab_model_synced_window_delegate_getter.h View 1 chunk +43 lines, -0 lines 0 comments Download
A ios/chrome/browser/tabs/tab_model_synced_window_delegate_getter.mm View 1 chunk +47 lines, -0 lines 0 comments Download
A ios/chrome/browser/tabs/tab_model_unittest.mm View 1 chunk +900 lines, -0 lines 0 comments Download
A ios/chrome/browser/tabs/tab_private.h View 1 chunk +36 lines, -0 lines 0 comments Download
A ios/chrome/browser/tabs/tab_snapshotting_delegate.h View 1 chunk +21 lines, -0 lines 0 comments Download
A ios/chrome/browser/tabs/tab_unittest.mm View 1 chunk +559 lines, -0 lines 0 comments Download
A ios/chrome/browser/test/perf_test_with_bvc_ios.h View 1 chunk +63 lines, -0 lines 0 comments Download
A ios/chrome/browser/test/perf_test_with_bvc_ios.mm View 1 chunk +169 lines, -0 lines 0 comments Download
A ios/chrome/browser/translate/js_language_detection_manager_unittest.mm View 1 chunk +351 lines, -0 lines 0 comments Download
A ios/chrome/browser/translate/translate_egtest.mm View 1 chunk +845 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/actions/README.md View 1 chunk +26 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/actions/settings_actions.h View 1 chunk +21 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/actions/tab_grid_actions.h View 1 chunk +21 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/actions/tools_menu_actions.h View 1 chunk +28 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/activity_services/activity_service_controller.h View 1 chunk +24 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/activity_services/activity_service_controller.mm View 1 chunk +303 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/activity_services/activity_service_controller_egtest.mm View 1 chunk +157 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/activity_services/activity_service_controller_unittest.mm View 1 chunk +480 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
sdefresne
Please take a look.
4 years ago (2016-12-19 12:22:58 UTC) #4
rohitrao (ping after 24h)
lgtm!
4 years ago (2016-12-19 12:36:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2585233003/1
4 years ago (2016-12-19 12:36:39 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-19 12:43:40 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-19 12:46:08 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/67dfdd6846a48ab001e262bcce04345a7ceb97d0
Cr-Commit-Position: refs/heads/master@{#439454}

Powered by Google App Engine
This is Rietveld 408576698