Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2585233002:
Clamp radii in FEMorphology::createImageFilter (Closed)
|
Created:
4 years ago by fs Modified:
4 years ago CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionClamp radii in FEMorphology::createImageFilter
Sk{Dilate,Erode}ImageFilter::Make take the radii as integers (int), so
make sure to convert the float FEMorphology stores avoiding overflow.
BUG=675164
Committed: https://crrev.com/84321d8133327259cf7eda6ed5bb19792fe94bda
Cr-Commit-Position: refs/heads/master@{#439474}
Patch Set 1 #
Total comments: 2
Messages
Total messages: 20 (10 generated)
Description was changed from
==========
Clamp radii in FEMorphology
Sk{Dilate,Erode}ImageFilter::Make take the radii as integers (int), so
make sure to convert the float FEMorphology stores avoiding overflow.
BUG=675164
==========
to
==========
Clamp radii in FEMorphology::createImageFilter
Sk{Dilate,Erode}ImageFilter::Make take the radii as integers (int), so
make sure to convert the float FEMorphology stores avoiding overflow.
BUG=675164
==========
The CQ bit was checked by fs@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
fs@opera.com changed reviewers: + fmalita@chromium.org, schenney@chromium.org
https://codereview.chromium.org/2585233002/diff/1/third_party/WebKit/Source/p... File third_party/WebKit/Source/platform/graphics/filters/FEMorphology.cpp (right): https://codereview.chromium.org/2585233002/diff/1/third_party/WebKit/Source/p... third_party/WebKit/Source/platform/graphics/filters/FEMorphology.cpp:96: int radiusY = clampTo<int>(getFilter()->applyVerticalScale(m_radiusY)); Does clampTo<SkScalar> work?
https://codereview.chromium.org/2585233002/diff/1/third_party/WebKit/Source/p... File third_party/WebKit/Source/platform/graphics/filters/FEMorphology.cpp (right): https://codereview.chromium.org/2585233002/diff/1/third_party/WebKit/Source/p... third_party/WebKit/Source/platform/graphics/filters/FEMorphology.cpp:96: int radiusY = clampTo<int>(getFilter()->applyVerticalScale(m_radiusY)); On 2016/12/19 at 14:21:14, Stephen Chennney wrote: > Does clampTo<SkScalar> work? SkScalar is typedef'd to float (or double, but I think float is the config used), so then we'd still be in the same boat.
On 2016/12/19 14:21:14, Stephen Chennney wrote: > https://codereview.chromium.org/2585233002/diff/1/third_party/WebKit/Source/p... > File third_party/WebKit/Source/platform/graphics/filters/FEMorphology.cpp > (right): > > https://codereview.chromium.org/2585233002/diff/1/third_party/WebKit/Source/p... > third_party/WebKit/Source/platform/graphics/filters/FEMorphology.cpp:96: int > radiusY = clampTo<int>(getFilter()->applyVerticalScale(m_radiusY)); > Does clampTo<SkScalar> work? OK, thanks. Seems like this is really a bug in Skia, though, if they take an SkScalar but need it to be an int. I'm happy to land this but could you please file a bug on Skia if they do indeed have the type mismatch internally. https://bugs.chromium.org/p/skia/issues/list
lgtm
lgtm
On 2016/12/19 at 14:32:28, schenney wrote: > On 2016/12/19 14:21:14, Stephen Chennney wrote: > > https://codereview.chromium.org/2585233002/diff/1/third_party/WebKit/Source/p... > > File third_party/WebKit/Source/platform/graphics/filters/FEMorphology.cpp > > (right): > > > > https://codereview.chromium.org/2585233002/diff/1/third_party/WebKit/Source/p... > > third_party/WebKit/Source/platform/graphics/filters/FEMorphology.cpp:96: int > > radiusY = clampTo<int>(getFilter()->applyVerticalScale(m_radiusY)); > > Does clampTo<SkScalar> work? > > OK, thanks. Seems like this is really a bug in Skia, though, if they take an SkScalar but need it to be an int. > > I'm happy to land this but could you please file a bug on Skia if they do indeed have the type mismatch internally. https://bugs.chromium.org/p/skia/issues/list No, Skia should be fine, it expects an 'int' [1], but we were passing it an SkScalar. [1] https://cs.chromium.org/chromium/src/third_party/skia/include/effects/SkMorph...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by fs@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1482159059582320, "parent_rev":
"07a13dce881c3ad2aaaadfee32549bfe5d082d56", "commit_rev":
"151c982cc0581ebce69442cdeb2c6095dcb4c30c"}
Message was sent while issue was closed.
Description was changed from
==========
Clamp radii in FEMorphology::createImageFilter
Sk{Dilate,Erode}ImageFilter::Make take the radii as integers (int), so
make sure to convert the float FEMorphology stores avoiding overflow.
BUG=675164
==========
to
==========
Clamp radii in FEMorphology::createImageFilter
Sk{Dilate,Erode}ImageFilter::Make take the radii as integers (int), so
make sure to convert the float FEMorphology stores avoiding overflow.
BUG=675164
Review-Url: https://codereview.chromium.org/2585233002
==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from
==========
Clamp radii in FEMorphology::createImageFilter
Sk{Dilate,Erode}ImageFilter::Make take the radii as integers (int), so
make sure to convert the float FEMorphology stores avoiding overflow.
BUG=675164
Review-Url: https://codereview.chromium.org/2585233002
==========
to
==========
Clamp radii in FEMorphology::createImageFilter
Sk{Dilate,Erode}ImageFilter::Make take the radii as integers (int), so
make sure to convert the float FEMorphology stores avoiding overflow.
BUG=675164
Committed: https://crrev.com/84321d8133327259cf7eda6ed5bb19792fe94bda
Cr-Commit-Position: refs/heads/master@{#439474}
==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/84321d8133327259cf7eda6ed5bb19792fe94bda Cr-Commit-Position: refs/heads/master@{#439474} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
