Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2585213004: Fixed bugs in ColorSpace typemap (Closed)

Created:
4 years ago by Alex Z.
Modified:
4 years ago
Reviewers:
Tom Sepez, sadrul
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed bugs in ColorSpace typemap Fixed typo in color_space.typemap Added color_space.typemap to typemaps.gni BUG=670364 Committed: https://crrev.com/e27afd717cd6d79d614cdfa3cfb202f12f169ddc Cr-Commit-Position: refs/heads/master@{#439502}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M ui/gfx/mojo/color_space.typemap View 1 chunk +2 lines, -1 line 0 comments Download
M ui/gfx/typemaps.gni View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Alex Z.
sadrul@: Please review the changes in typemaps.gni. tsepez@: Please review the changes in color_space.typemap.
4 years ago (2016-12-19 16:56:07 UTC) #4
sadrul
lgtm
4 years ago (2016-12-19 16:57:51 UTC) #5
Tom Sepez
lgtm RS
4 years ago (2016-12-19 17:42:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2585213004/1
4 years ago (2016-12-19 17:51:09 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-19 17:57:01 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-19 17:59:28 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e27afd717cd6d79d614cdfa3cfb202f12f169ddc
Cr-Commit-Position: refs/heads/master@{#439502}

Powered by Google App Engine
This is Rietveld 408576698