Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2585193004: [wasm] Add js-api test and fix property details for some functions. (Closed)

Created:
4 years ago by titzer
Modified:
4 years ago
Reviewers:
Clemens Hammacher
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Add js-api test and fix property details for some functions. R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2585193004 Cr-Commit-Position: refs/heads/master@{#41817} Committed: https://chromium.googlesource.com/v8/v8/+/b6a57e6ff5ed7f6db3ff503e245a1f9535e968cc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+563 lines, -5 lines) Patch
M src/wasm/wasm-js.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M src/wasm/wasm-module.cc View 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/wasm/js-api.js View 1 chunk +559 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
titzer
4 years ago (2016-12-19 16:38:14 UTC) #1
Clemens Hammacher
lgtm
4 years ago (2016-12-19 17:08:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2585193004/1
4 years ago (2016-12-19 17:18:01 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-19 17:20:00 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/b6a57e6ff5ed7f6db3ff503e245a1f9535e...

Powered by Google App Engine
This is Rietveld 408576698