Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2585163002: Clarify the strings in the external protocol dialog. (Closed)

Created:
4 years ago by dominickn
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Clarify the strings in the external protocol dialog. Currently, clicking "Cancel" in an external protocol dialog with the "Always open links for <app>" option checked will permanently silence all protocol requests for that scheme. This result is unexpected given the strings. This CL updates the strings to clarify the behaviour. This is a stopgap fix for M56; future milestones will see further changes to the behaviour of this dialog to improve its usability. BUG=671658 Review-Url: https://codereview.chromium.org/2581623002 Cr-Commit-Position: refs/heads/master@{#439001} (cherry picked from commit eb32611eaf94923d6cfb2d0965603c63de4c4178) Committed: https://chromium.googlesource.com/chromium/src/+/a44cc09a52bb8fc8931a8763bb2cb6fc2b86fa7f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/external_protocol_dialog.mm View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/external_protocol_dialog_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
dominickn
4 years ago (2016-12-19 05:52:39 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
a44cc09a52bb8fc8931a8763bb2cb6fc2b86fa7f.

Powered by Google App Engine
This is Rietveld 408576698