Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2585133002: [builtins] move PromiseBuiltinsAssembler to it's own header file (Closed)

Created:
4 years ago by gsathya
Modified:
4 years ago
Reviewers:
Igor Sheludko, jgruber
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] move PromiseBuiltinsAssembler to it's own header file BUG=v8:5343 Review-Url: https://codereview.chromium.org/2585133002 Cr-Commit-Position: refs/heads/master@{#41816} Committed: https://chromium.googlesource.com/v8/v8/+/81f765718e084008b175cce7bf7db18db2addbf0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -30 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A src/builtins/builtins-promise.h View 1 chunk +44 lines, -0 lines 0 comments Download
M src/builtins/builtins-promise.cc View 2 chunks +1 line, -30 lines 0 comments Download
M src/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-code-stub-assembler.cc View 2 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
jgruber
lgtm
4 years ago (2016-12-19 08:38:44 UTC) #7
Igor Sheludko
lgtm
4 years ago (2016-12-19 08:41:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2585133002/1
4 years ago (2016-12-19 17:13:00 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-19 17:14:48 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/81f765718e084008b175cce7bf7db18db2a...

Powered by Google App Engine
This is Rietveld 408576698