Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1178)

Issue 2585113005: DevTools: make ignoreInputEvents a static flag (Closed)

Created:
4 years ago by caseq
Modified:
4 years ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, mlamouri+watch-blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, dcheng, devtools-reviews_chromium.org, blink-reviews, kinuko+watch, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: make ignoreInputEvents a static flag This makes ignoreInputEvents a static flag and moved it to WebFrameWidgetBase, removing all the logic we used to propagate it to all instances of WebViewImpl and WebFrameWidgetImpl within the process. The only anticipated side effect is that newly created pages in the same process would ignore input events while we're on inner message loop, which seems like a good thing. Committed: https://crrev.com/aa30f599c5b220cd1ac0a6eb8168626aef2c3f7c Cr-Commit-Position: refs/heads/master@{#439692}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -102 lines) Patch
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.h View 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp View 5 chunks +4 lines, -65 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetBase.h View 2 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetBase.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetImpl.h View 3 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp View 5 chunks +1 line, -17 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.h View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 4 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
caseq
4 years ago (2016-12-20 00:51:38 UTC) #2
dgozman
lgtm
4 years ago (2016-12-20 01:14:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2585113005/1
4 years ago (2016-12-20 02:01:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/64177bc40ac1fd5359a93a24d0587c0e08a07737
4 years ago (2016-12-20 03:32:37 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-20 03:34:14 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aa30f599c5b220cd1ac0a6eb8168626aef2c3f7c
Cr-Commit-Position: refs/heads/master@{#439692}

Powered by Google App Engine
This is Rietveld 408576698