Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2584983002: Fixed disabled status of Find-in-page previous/next arrows (Closed)

Created:
4 years ago by shaktisahu
Modified:
4 years ago
Reviewers:
Ted C
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed disabled status of Find-in-page previous/next arrows Currently the previous/next arrows are not disabled when there is no text match. Fixed this. BUG=509857 Committed: https://crrev.com/effa7da6e9de09d34e8ab967c6fc6d846ee50687 Cr-Commit-Position: refs/heads/master@{#439532}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/widget/findinpage/FindToolbar.java View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
shaktisahu
4 years ago (2016-12-16 23:43:54 UTC) #2
Ted C
lgtm
4 years ago (2016-12-19 16:02:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2584983002/1
4 years ago (2016-12-19 18:40:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-19 20:05:37 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-19 20:08:10 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/effa7da6e9de09d34e8ab967c6fc6d846ee50687
Cr-Commit-Position: refs/heads/master@{#439532}

Powered by Google App Engine
This is Rietveld 408576698