Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 2584973002: [Sync] Fix account info string on PassphraseDialogFragment on android. (Closed)

Created:
4 years ago by pavely
Modified:
4 years ago
Reviewers:
maxbogue
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Fix account info string on PassphraseDialogFragment on android. Recent change caused passphrase dialog to show "On - sync everything" instead of "Signed in as <email>" on Passphrase dialog on android. I'm reverting this behavior. R=maxbogue@chromium.org BUG=674733 Committed: https://crrev.com/a550d22543489b144cd014eebf6a1255de52eeb0 Cr-Commit-Position: refs/heads/master@{#439478}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M chrome/browser/sync/profile_sync_service_android.cc View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
pavely
4 years ago (2016-12-17 00:13:16 UTC) #5
maxbogue
lgtm lgtm
4 years ago (2016-12-19 15:20:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2584973002/1
4 years ago (2016-12-19 15:20:13 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-19 15:47:32 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-19 15:49:54 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a550d22543489b144cd014eebf6a1255de52eeb0
Cr-Commit-Position: refs/heads/master@{#439478}

Powered by Google App Engine
This is Rietveld 408576698