Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2584933002:
Android ScreenCapture: fix crash on Nexus 5X (Closed)
|
Created:
4 years ago by braveyao Modified:
4 years ago Reviewers:
miu CC:
chromium-reviews, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, agrieve+watch_chromium.org, xjz+watch_chromium.org, miu+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAndroid ScreenCapture: fix crash on Nexus 5X
YUV420 is preferred but not supported on all devices. On Nexus 5X(7.1.1),
instead of throwing an unsupported exception, it just crashes directly.
So far RGBA_8888 works everywhere, then we still need to keep it as the default
format for now. A feature request was already filed to support YUV420 in Android
in the future.
BUG=674989
Committed: https://crrev.com/27589f055c9f7b8198c86cf7b6a7fb16eb515534
Cr-Commit-Position: refs/heads/master@{#439288}
Patch Set 1 #
Total comments: 1
Patch Set 2 : address comments #Messages
Total messages: 19 (14 generated)
The CQ bit was checked by braveyao@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
braveyao@chromium.org changed reviewers: + miu@chromium.org
Hi miu@, please take a look!
lgtm https://codereview.chromium.org/2584933002/diff/1/media/capture/content/andro... File media/capture/content/android/java/src/org/chromium/media/ScreenCapture.java (right): https://codereview.chromium.org/2584933002/diff/1/media/capture/content/andro... media/capture/content/android/java/src/org/chromium/media/ScreenCapture.java:302: // crash some devices. see https://crbug.com/674989 . A feature request nit: s/see/See/
The CQ bit was checked by braveyao@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by braveyao@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from miu@chromium.org Link to the patchset: https://codereview.chromium.org/2584933002/#ps20001 (title: "address comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481941008030450,
"parent_rev": "9a07bbe466c3cd333f8a23c77fdd149422f241a8", "commit_rev":
"a7c8fd746dbdd34d045843a553d015b609dbdbde"}
Message was sent while issue was closed.
Description was changed from ========== Android ScreenCapture: fix crash on Nexus 5X YUV420 is preferred but not supported on all devices. On Nexus 5X(7.1.1), instead of throwing an unsupported exception, it just crashes directly. So far RGBA_8888 works everywhere, then we still need to keep it as the default format for now. A feature request was already filed to support YUV420 in Android in the future. BUG=674989 ========== to ========== Android ScreenCapture: fix crash on Nexus 5X YUV420 is preferred but not supported on all devices. On Nexus 5X(7.1.1), instead of throwing an unsupported exception, it just crashes directly. So far RGBA_8888 works everywhere, then we still need to keep it as the default format for now. A feature request was already filed to support YUV420 in Android in the future. BUG=674989 Review-Url: https://codereview.chromium.org/2584933002 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Android ScreenCapture: fix crash on Nexus 5X YUV420 is preferred but not supported on all devices. On Nexus 5X(7.1.1), instead of throwing an unsupported exception, it just crashes directly. So far RGBA_8888 works everywhere, then we still need to keep it as the default format for now. A feature request was already filed to support YUV420 in Android in the future. BUG=674989 Review-Url: https://codereview.chromium.org/2584933002 ========== to ========== Android ScreenCapture: fix crash on Nexus 5X YUV420 is preferred but not supported on all devices. On Nexus 5X(7.1.1), instead of throwing an unsupported exception, it just crashes directly. So far RGBA_8888 works everywhere, then we still need to keep it as the default format for now. A feature request was already filed to support YUV420 in Android in the future. BUG=674989 Committed: https://crrev.com/27589f055c9f7b8198c86cf7b6a7fb16eb515534 Cr-Commit-Position: refs/heads/master@{#439288} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/27589f055c9f7b8198c86cf7b6a7fb16eb515534 Cr-Commit-Position: refs/heads/master@{#439288} |
