|
|
Created:
4 years ago by gab Modified:
4 years ago Reviewers:
Avi (use Gerrit) CC:
chromium-reviews, jam, darin-cc_chromium.org, fdoray, robliao Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRedirect BrowserThread::FILE at USER_VISIBLE instead of BACKGROUND priority.
An oversight in https://codereview.chromium.org/2464233002/. Although
FILE should mostly be for BACKGROUND work, there are some USER_VISIBLE
tasks on it and as such it has to be redirected as USER_VISIBLE until
migration of individual tasks can clarify per task priority (just like
BlockingPool is redirected as USER_VISIBLE).
BUG=653916
TBR=avi@chromium.org
NO_DEPENDENCY_CHECKS=true
Committed: https://crrev.com/7b5334b8262bbbce140fb2dcc3aeb4034d5d0dbe
Cr-Commit-Position: refs/heads/master@{#439240}
Patch Set 1 #Patch Set 2 : kill fake dependency #
Messages
Total messages: 17 (11 generated)
gab@chromium.org changed reviewers: + avi@chromium.org
TBR avi for slight post-commit tweak to https://codereview.chromium.org/2464233002/.
Description was changed from ========== Redirect BrowserThread::FILE at USER_VISIBLE instead of BACKGROUND priority. An oversight in https://codereview.chromium.org/2464233002/. Although FILE should mostly be for BACKGROUND work, there are some USER_VISIBLE tasks on it and as such it has to be redirected as USER_VISIBLE until migration of individual tasks can clarify per task priority (just like BlockingPool is redirected as USER_VISIBLE). BUG=653916 ========== to ========== Redirect BrowserThread::FILE at USER_VISIBLE instead of BACKGROUND priority. An oversight in https://codereview.chromium.org/2464233002/. Although FILE should mostly be for BACKGROUND work, there are some USER_VISIBLE tasks on it and as such it has to be redirected as USER_VISIBLE until migration of individual tasks can clarify per task priority (just like BlockingPool is redirected as USER_VISIBLE). BUG=653916 TBR=avi@chromium.org ==========
The CQ bit was checked by gab@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 2576243003 Patch 100001). Please resolve the dependency and try again. If you are sure that there is no real dependency, please use one of the options listed in https://goo.gl/9Es4OR to land the CL.
Description was changed from ========== Redirect BrowserThread::FILE at USER_VISIBLE instead of BACKGROUND priority. An oversight in https://codereview.chromium.org/2464233002/. Although FILE should mostly be for BACKGROUND work, there are some USER_VISIBLE tasks on it and as such it has to be redirected as USER_VISIBLE until migration of individual tasks can clarify per task priority (just like BlockingPool is redirected as USER_VISIBLE). BUG=653916 TBR=avi@chromium.org ========== to ========== Redirect BrowserThread::FILE at USER_VISIBLE instead of BACKGROUND priority. An oversight in https://codereview.chromium.org/2464233002/. Although FILE should mostly be for BACKGROUND work, there are some USER_VISIBLE tasks on it and as such it has to be redirected as USER_VISIBLE until migration of individual tasks can clarify per task priority (just like BlockingPool is redirected as USER_VISIBLE). BUG=653916 TBR=avi@chromium.org NO_DEPENDENCY_CHECKS=true ==========
The CQ bit was checked by gab@chromium.org
The CQ bit was unchecked by gab@chromium.org
The CQ bit was checked by gab@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481915611260870, "parent_rev": "2ad31fad67b74e0b1adf79003e4bd126fcd805a4", "commit_rev": "9f1dbe5310af54f1b7975e5887cd16aad7ecf9fc"}
Message was sent while issue was closed.
Description was changed from ========== Redirect BrowserThread::FILE at USER_VISIBLE instead of BACKGROUND priority. An oversight in https://codereview.chromium.org/2464233002/. Although FILE should mostly be for BACKGROUND work, there are some USER_VISIBLE tasks on it and as such it has to be redirected as USER_VISIBLE until migration of individual tasks can clarify per task priority (just like BlockingPool is redirected as USER_VISIBLE). BUG=653916 TBR=avi@chromium.org NO_DEPENDENCY_CHECKS=true ========== to ========== Redirect BrowserThread::FILE at USER_VISIBLE instead of BACKGROUND priority. An oversight in https://codereview.chromium.org/2464233002/. Although FILE should mostly be for BACKGROUND work, there are some USER_VISIBLE tasks on it and as such it has to be redirected as USER_VISIBLE until migration of individual tasks can clarify per task priority (just like BlockingPool is redirected as USER_VISIBLE). BUG=653916 TBR=avi@chromium.org NO_DEPENDENCY_CHECKS=true Review-Url: https://codereview.chromium.org/2584923002 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Redirect BrowserThread::FILE at USER_VISIBLE instead of BACKGROUND priority. An oversight in https://codereview.chromium.org/2464233002/. Although FILE should mostly be for BACKGROUND work, there are some USER_VISIBLE tasks on it and as such it has to be redirected as USER_VISIBLE until migration of individual tasks can clarify per task priority (just like BlockingPool is redirected as USER_VISIBLE). BUG=653916 TBR=avi@chromium.org NO_DEPENDENCY_CHECKS=true Review-Url: https://codereview.chromium.org/2584923002 ========== to ========== Redirect BrowserThread::FILE at USER_VISIBLE instead of BACKGROUND priority. An oversight in https://codereview.chromium.org/2464233002/. Although FILE should mostly be for BACKGROUND work, there are some USER_VISIBLE tasks on it and as such it has to be redirected as USER_VISIBLE until migration of individual tasks can clarify per task priority (just like BlockingPool is redirected as USER_VISIBLE). BUG=653916 TBR=avi@chromium.org NO_DEPENDENCY_CHECKS=true Committed: https://crrev.com/7b5334b8262bbbce140fb2dcc3aeb4034d5d0dbe Cr-Commit-Position: refs/heads/master@{#439240} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/7b5334b8262bbbce140fb2dcc3aeb4034d5d0dbe Cr-Commit-Position: refs/heads/master@{#439240} |