Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2584923002: Redirect BrowserThread::FILE at USER_VISIBLE instead of BACKGROUND priority. (Closed)

Created:
4 years ago by gab
Modified:
4 years ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, jam, darin-cc_chromium.org, fdoray, robliao
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Redirect BrowserThread::FILE at USER_VISIBLE instead of BACKGROUND priority. An oversight in https://codereview.chromium.org/2464233002/. Although FILE should mostly be for BACKGROUND work, there are some USER_VISIBLE tasks on it and as such it has to be redirected as USER_VISIBLE until migration of individual tasks can clarify per task priority (just like BlockingPool is redirected as USER_VISIBLE). BUG=653916 TBR=avi@chromium.org NO_DEPENDENCY_CHECKS=true Committed: https://crrev.com/7b5334b8262bbbce140fb2dcc3aeb4034d5d0dbe Cr-Commit-Position: refs/heads/master@{#439240}

Patch Set 1 #

Patch Set 2 : kill fake dependency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/browser_main_loop.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (11 generated)
gab
TBR avi for slight post-commit tweak to https://codereview.chromium.org/2464233002/.
4 years ago (2016-12-16 19:09:52 UTC) #2
commit-bot: I haz the power
This CL has an open dependency (Issue 2576243003 Patch 100001). Please resolve the dependency and ...
4 years ago (2016-12-16 19:10:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2584923002/20001
4 years ago (2016-12-16 19:14:15 UTC) #11
Avi (use Gerrit)
lgtm
4 years ago (2016-12-16 19:14:17 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-17 00:06:24 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-17 00:11:04 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7b5334b8262bbbce140fb2dcc3aeb4034d5d0dbe
Cr-Commit-Position: refs/heads/master@{#439240}

Powered by Google App Engine
This is Rietveld 408576698