Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 25849004: Clean up unused constant globals (Closed)

Created:
7 years, 2 months ago by hans
Modified:
7 years, 2 months ago
Reviewers:
Nico
CC:
chromium-reviews, asanka, amit, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, benjhayden+dwatch_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, dbeam+watch-options_chromium.org, dcaiafa+watch_chromium.org, wez+watch_chromium.org, sanjeevr, feature-media-reviews_chromium.org, rmsousa+watch_chromium.org, weitaosu+watch_chromium.org, sergeyu+watch_chromium.org, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, James Su, agl, jln+watch_chromium.org, Mark Mentovai, acolwell GONE FROM CHROMIUM, alexeypa (please no reviews), Markus (顧孟勤), brettw
Visibility:
Public.

Description

Clean up unused constant globals Found by clang's new -Wunused-const-variable. BUG=290204 TBR=mark, acolwell, agl, alexeypa, markus, brettw Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226888

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix base/debug/stack_trace_posix.cc #

Patch Set 3 : fix chrome/app/breakpad_linux.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -63 lines) Patch
M base/debug/stack_trace_posix.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M base/time/time_posix.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/app/breakpad_linux.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/apps/app_launcher_util.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/updater/extension_updater.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/jankometer.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/performance_monitor/performance_monitor.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/gtk/browser_titlebar.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/gtk/create_application_shortcuts_dialog_gtk.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/download/download_started_animation_gtk.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/gtk/extensions/extension_uninstall_dialog_gtk.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/fullscreen_exit_bubble_gtk.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/infobars/infobar_gtk.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/gtk/notifications/balloon_view_gtk.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/tabs/tab_renderer_gtk.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/local_discovery/local_discovery_ui_browsertest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/certificate_manager_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_content_client.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/renderer/printing/print_web_view_helper_browsertest.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M media/tools/player_x11/gl_video_renderer.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M net/base/address_tracker_linux_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/tools/quic/quic_server.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/websockets/websocket_basic_stream_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/host/server_log_entry.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M sandbox/linux/seccomp-bpf/sandbox_bpf_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M tools/gn/command_gyp.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
hans
These are the ones I found doing a full build on Linux.
7 years, 2 months ago (2013-10-03 18:24:34 UTC) #1
Nico
lgtm! I fear there will be some more of these in the views/ code…
7 years, 2 months ago (2013-10-03 18:45:48 UTC) #2
hans
tbr: mark, acolwell, agl, alexeypa, markus, brettw
7 years, 2 months ago (2013-10-03 19:27:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/25849004/1
7 years, 2 months ago (2013-10-03 19:29:21 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 2 months ago (2013-10-03 19:53:36 UTC) #5
Nico
https://codereview.chromium.org/25849004/diff/1/base/debug/stack_trace_posix.cc File base/debug/stack_trace_posix.cc (right): https://codereview.chromium.org/25849004/diff/1/base/debug/stack_trace_posix.cc#newcode46 base/debug/stack_trace_posix.cc:46: #if !defined(USE_SYMBOLIZE) && defined(_GLIBCXX__) Err, this should be __GLIBCXX__ ...
7 years, 2 months ago (2013-10-03 19:57:11 UTC) #6
hans
On 2013/10/03 19:57:11, Nico wrote: > https://codereview.chromium.org/25849004/diff/1/base/debug/stack_trace_posix.cc > File base/debug/stack_trace_posix.cc (right): > > https://codereview.chromium.org/25849004/diff/1/base/debug/stack_trace_posix.cc#newcode46 > ...
7 years, 2 months ago (2013-10-03 19:58:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/25849004/32001
7 years, 2 months ago (2013-10-03 20:02:33 UTC) #8
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 2 months ago (2013-10-03 20:34:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/25849004/13001
7 years, 2 months ago (2013-10-03 20:46:45 UTC) #10
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 2 months ago (2013-10-03 21:01:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/25849004/13001
7 years, 2 months ago (2013-10-03 21:04:32 UTC) #12
commit-bot: I haz the power
7 years, 2 months ago (2013-10-03 23:26:26 UTC) #13
Message was sent while issue was closed. 
Change committed as 226888

Powered by Google App Engine
This is Rietveld 408576698