Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Issue 2584843002: Implement LinkError; import tweaks (Closed)

Created:
4 years ago by rossberg
Modified:
4 years ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com, bradnelson
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Implement LinkError; import tweaks - Implement new WebAssembly.LinkError exception - Implement stricter checks for glboal imports - Add tests - Refactor handling of import names - Add TODOs for empty import names R=titzer@chromium.org BUG= Review-Url: https://codereview.chromium.org/2584843002 Cr-Commit-Position: refs/heads/master@{#41764} Committed: https://chromium.googlesource.com/v8/v8/+/16fe4263200532191c4633a96714cec7b6e23510

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -92 lines) Patch
M src/bootstrapper.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/contexts.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/factory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap-symbols.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/wasm/wasm-js.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/wasm/wasm-module.cc View 10 chunks +64 lines, -71 lines 0 comments Download
M src/wasm/wasm-result.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/wasm/wasm-result.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M test/mjsunit/wasm/errors.js View 4 chunks +28 lines, -19 lines 0 comments Download
M test/mjsunit/wasm/export-table.js View 1 chunk +21 lines, -0 lines 0 comments Download
M test/mjsunit/wasm/globals.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/wasm/import-table.js View 2 chunks +21 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
rossberg
4 years ago (2016-12-16 13:32:00 UTC) #1
rossberg
@bradnelson: FYI. I signed you up for the empty import name TODO, since the misbehaviour ...
4 years ago (2016-12-16 13:35:03 UTC) #3
titzer
lgtm
4 years ago (2016-12-16 13:37:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2584843002/1
4 years ago (2016-12-16 13:43:35 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/16fe4263200532191c4633a96714cec7b6e23510
4 years ago (2016-12-16 14:23:46 UTC) #9
gsathya
4 years ago (2016-12-16 18:53:00 UTC) #10
Message was sent while issue was closed.
On 2016/12/16 14:23:46, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/v8/v8/+/16fe4263200532191c4633a96714cec7b6e...

Hmm not sure how this cleared the presubmit, my CL caught a bunch of formatting
issues caused by this --
https://codereview.chromium.org/2575313002/

Powered by Google App Engine
This is Rietveld 408576698